Remove GLFrameData from CompositorFrame.

Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/5344b39e46eb35c82e09b6fabc5447dbf68ff393
Cr-Commit-Position: refs/heads/master@{#423746}

[kylechar, 2016-09-30 17:02:47]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Change OutputSurface::SwapBuffer() interface to take OutputSurfaceFrame
instead of a CompositorFrame. Create new struct OutputSurfaceFrame that
contains relevant info.

BUG=651851
==========

to

==========
Remove GLFrameData from CompositorFrame.

Change OutputSurface::SwapBuffer() interface to take OutputSurfaceFrame
instead of a CompositorFrame. Create new struct OutputSurfaceFrame that
contains relevant info.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[kylechar, 2016-09-30 18:51:01]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-09-30 19:29:17]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 19:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:09:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-09-30 21:17:45]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Change OutputSurface::SwapBuffer() interface to take OutputSurfaceFrame
instead of a CompositorFrame. Create new struct OutputSurfaceFrame that
contains relevant info.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[kylechar, 2016-09-30 21:18:19]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org

[kylechar, 2016-09-30 21:18:20]

I'm OOO Monday so no rush on reviewing.

[kylechar, 2016-09-30 21:29:51]

Patchset #4 (id:80001) has been deleted

[danakj, 2016-10-04 21:58:41]

Thanks for working on this, it's great!

https://codereview.chromium.org/2374183006/diff/120001/cc/output/compositor_f...
File cc/output/compositor_frame.h (left):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/compositor_f...
cc/output/compositor_frame.h:34: std::unique_ptr<DelegatedFrameData>
delegated_frame_data;
I nice followup would be to merge the fields in DelegatedFrameData up into this
class now.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer....
cc/output/gl_renderer.cc:2887: void
GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
Can you make this method take a vector of latencyinfo instead of a full
metadata?

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer....
cc/output/gl_renderer.cc:2895: OutputSurfaceFrame frame;
nit: name the variable output_frame or something a bit more than |frame| which
is a suuper common word.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface.h (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface.h:18: #include "cc/output/output_surface_frame.h"
forward declare it instead?

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface.h:39: class CompositorFrame;
remove this

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface_frame.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.cc:9: OutputSurfaceFrame::OutputSurfaceFrame() {}
 = default

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.cc:14: OutputSurfaceFrame::~OutputSurfaceFrame()
{}
 = default

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface_frame.h (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.h:20: OutputSurfaceFrame(const
OutputSurfaceFrame& other);
copy constructors should come with operator=, but I don't think this should be
copyable? CompositorFrame is move-only, can this be also?

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
cc/output/software_renderer.cc:84: void
SoftwareRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
same here, can it take vector instead of full metadata?

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
cc/output/software_renderer.cc:87: OutputSurfaceFrame frame;
nit: output_frame or something?

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_composito...
File cc/test/fake_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_composito...
cc/test/fake_compositor_frame_sink.cc:35: // Unknown for direct software frames.
There's no direct frame here anymore, can you remove this comment?

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_output_su...
File cc/test/fake_output_surface.h (left):

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_output_su...
cc/test/fake_output_surface.h:107: void ReturnResourcesHeldByParent();
Thanks for finding dead code :)

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
File content/browser/compositor/gpu_browser_compositor_output_surface.h (right):

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
content/browser/compositor/gpu_browser_compositor_output_surface.h:81: private:
Good call!

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
File content/browser/compositor/mus_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
content/browser/compositor/mus_browser_compositor_output_surface.cc:44:
ui_frame.metadata.latency_info = frame.latency_info;
Keep moving this? Moving a vector is much better than copying it.

https://codereview.chromium.org/2374183006/diff/120001/tools/ipc_fuzzer/fuzze...
File tools/ipc_fuzzer/fuzzer/fuzzer.cc (left):

https://codereview.chromium.org/2374183006/diff/120001/tools/ipc_fuzzer/fuzze...
tools/ipc_fuzzer/fuzzer/fuzzer.cc:685: switch (RandInRange(3)) {
Reduce this range to match?

[kylechar, 2016-10-05 13:40:22]

Patchset #6 (id:140001) has been deleted

[kylechar, 2016-10-05 13:45:55]

OutputSurfaceFrame could use a summary comment. Any suggestions? I have a
cursory understand of what data gets passed with it and sort of how it's used
but definitely don't understand all of whys.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/compositor_f...
File cc/output/compositor_frame.h (left):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/compositor_f...
cc/output/compositor_frame.h:34: std::unique_ptr<DelegatedFrameData>
delegated_frame_data;
On 2016/10/04 21:58:40, danakj wrote:
> I nice followup would be to merge the fields in DelegatedFrameData up into
this
> class now.

Acknowledged.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer....
cc/output/gl_renderer.cc:2887: void
GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
On 2016/10/04 21:58:40, danakj wrote:
> Can you make this method take a vector of latencyinfo instead of a full
> metadata?

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/gl_renderer....
cc/output/gl_renderer.cc:2895: OutputSurfaceFrame frame;
On 2016/10/04 21:58:40, danakj wrote:
> nit: name the variable output_frame or something a bit more than |frame| which
> is a suuper common word.

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface.h (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface.h:18: #include "cc/output/output_surface_frame.h"
On 2016/10/04 21:58:40, danakj wrote:
> forward declare it instead?

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface.h:39: class CompositorFrame;
On 2016/10/04 21:58:40, danakj wrote:
> remove this

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface_frame.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.cc:9: OutputSurfaceFrame::OutputSurfaceFrame() {}
On 2016/10/04 21:58:40, danakj wrote:
>  = default

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.cc:14: OutputSurfaceFrame::~OutputSurfaceFrame()
{}
On 2016/10/04 21:58:40, danakj wrote:
>  = default

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
File cc/output/output_surface_frame.h (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/output_surfa...
cc/output/output_surface_frame.h:20: OutputSurfaceFrame(const
OutputSurfaceFrame& other);
On 2016/10/04 21:58:40, danakj wrote:
> copy constructors should come with operator=, but I don't think this should be
> copyable? CompositorFrame is move-only, can this be also?

Good point about move-only, done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
cc/output/software_renderer.cc:84: void
SoftwareRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
On 2016/10/04 21:58:40, danakj wrote:
> same here, can it take vector instead of full metadata?

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/output/software_ren...
cc/output/software_renderer.cc:87: OutputSurfaceFrame frame;
On 2016/10/04 21:58:40, danakj wrote:
> nit: output_frame or something?

Done.

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_composito...
File cc/test/fake_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2374183006/diff/120001/cc/test/fake_composito...
cc/test/fake_compositor_frame_sink.cc:35: // Unknown for direct software frames.
On 2016/10/04 21:58:40, danakj wrote:
> There's no direct frame here anymore, can you remove this comment?

Done.

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
File content/browser/compositor/mus_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
content/browser/compositor/mus_browser_compositor_output_surface.cc:44:
ui_frame.metadata.latency_info = frame.latency_info;
On 2016/10/04 21:58:40, danakj wrote:
> Keep moving this? Moving a vector is much better than copying it.

That seems super unsafe? We pass |frame| to
GpuBrowserCompositorOutputSurface::SwapBuffers() after this and it uses the
|frame.latency_info| field.

Actually, I'm not totally sure how this worked before. I guess
GpuBrowserCompositorOutputSurface::SwapBuffers() doesn't really need the
latency_info or something?

https://codereview.chromium.org/2374183006/diff/120001/tools/ipc_fuzzer/fuzze...
File tools/ipc_fuzzer/fuzzer/fuzzer.cc (left):

https://codereview.chromium.org/2374183006/diff/120001/tools/ipc_fuzzer/fuzze...
tools/ipc_fuzzer/fuzzer/fuzzer.cc:685: switch (RandInRange(3)) {
On 2016/10/04 21:58:40, danakj wrote:
> Reduce this range to match?

Good catch, done.

[danakj, 2016-10-05 23:02:20]

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
File content/browser/compositor/mus_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
content/browser/compositor/mus_browser_compositor_output_surface.cc:44:
ui_frame.metadata.latency_info = frame.latency_info;
On 2016/10/05 13:45:54, kylechar wrote:
> On 2016/10/04 21:58:40, danakj wrote:
> > Keep moving this? Moving a vector is much better than copying it.
> 
> That seems super unsafe? We pass |frame| to
> GpuBrowserCompositorOutputSurface::SwapBuffers() after this and it uses the
> |frame.latency_info| field.
> 
> Actually, I'm not totally sure how this worked before. I guess
> GpuBrowserCompositorOutputSurface::SwapBuffers() doesn't really need the
> latency_info or something?

Oh wow. It does use the latency infoes:
https://cs.chromium.org/chromium/src/content/browser/compositor/gpu_browser_c...

However duplicating them doesn't sound right! This class basically renders into
a texture and then passes that texture along instead of the original resources.
So I think we should move the latency infos here (where they will continue on
later), and empty the |frame|'s vector. That's probably what was happening
before but undefined-like.

https://codereview.chromium.org/2374183006/diff/140002/cc/output/output_surfa...
File cc/output/output_surface_frame.h (right):

https://codereview.chromium.org/2374183006/diff/140002/cc/output/output_surfa...
cc/output/output_surface_frame.h:18: class CC_EXPORT OutputSurfaceFrame {
// Metadata given to the OutputSurface in order for it to swap what was drawn
for the current frame to become visible.

? or something like that.

[danakj, 2016-10-05 23:02:29]

LGTM after that

[kylechar, 2016-10-06 14:16:55]

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
File content/browser/compositor/mus_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2374183006/diff/120001/content/browser/compos...
content/browser/compositor/mus_browser_compositor_output_surface.cc:44:
ui_frame.metadata.latency_info = frame.latency_info;
On 2016/10/05 23:02:19, danakj wrote:
> On 2016/10/05 13:45:54, kylechar wrote:
> > On 2016/10/04 21:58:40, danakj wrote:
> > > Keep moving this? Moving a vector is much better than copying it.
> > 
> > That seems super unsafe? We pass |frame| to
> > GpuBrowserCompositorOutputSurface::SwapBuffers() after this and it uses the
> > |frame.latency_info| field.
> > 
> > Actually, I'm not totally sure how this worked before. I guess
> > GpuBrowserCompositorOutputSurface::SwapBuffers() doesn't really need the
> > latency_info or something?
> 
> Oh wow. It does use the latency infoes:
>
https://cs.chromium.org/chromium/src/content/browser/compositor/gpu_browser_c...
> 
> However duplicating them doesn't sound right! This class basically renders
into
> a texture and then passes that texture along instead of the original
resources.
> So I think we should move the latency infos here (where they will continue on
> later), and empty the |frame|'s vector. That's probably what was happening
> before but undefined-like.

Done.

https://codereview.chromium.org/2374183006/diff/140002/cc/output/output_surfa...
File cc/output/output_surface_frame.h (right):

https://codereview.chromium.org/2374183006/diff/140002/cc/output/output_surfa...
cc/output/output_surface_frame.h:18: class CC_EXPORT OutputSurfaceFrame {
On 2016/10/05 23:02:20, danakj wrote:
> // Metadata given to the OutputSurface in order for it to swap what was drawn
> for the current frame to become visible.
> 
> ? or something like that.

Done.

[kylechar, 2016-10-06 14:17:30]

kylechar@chromium.org changed reviewers:
+ dtrainor@chromium.org, fsamuel@google.com, michaelbai@chromium.org,
tsepez@chromium.org

[kylechar, 2016-10-06 14:17:31]

michaelbai: android_webview/*
dtrainor: blimp/*
tsepez: cc/ipc/*, tools/ipc_fuzzers/*
fsamuel: services/ui/surfaces/*

[kylechar, 2016-10-06 14:20:45]

kylechar@chromium.org changed reviewers:
+ aelias@chromium.org, fsamuel@chromium.org
- fsamuel@google.com

[kylechar, 2016-10-06 14:20:46]

Oops, correct fsamuel this time. Also missing OWNERS for a couple last files.

aelias: content/browser/renderer_host/compositor_impl_android.cc and
content/renderer/android/synchronous_compositor_frame_sink.cc

[kylechar, 2016-10-06 16:50:10]

Patchset #7 (id:170001) has been deleted

[Tom Sepez, 2016-10-06 18:36:08]

ipc/fuzzer LGTM

[michaelbai, 2016-10-06 18:53:04]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[michaelbai, 2016-10-06 18:53:05]

michaelbai@chromium.org changed reviewers:
+ boliu@chromium.org

[michaelbai, 2016-10-06 18:53:45]

add boliu for android_wevbiew

[boliu, 2016-10-06 19:02:30]

android_webview and android bits in content lgtm

[aelias_OOO_until_Jul13, 2016-10-06 19:05:38]

lgtm

[kylechar, 2016-10-06 19:06:25]

kylechar@chromium.org changed reviewers:
- michaelbai@chromium.org

[kylechar, 2016-10-06 20:59:57]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 21:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:59:57]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-10-06 23:42:27]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR= dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[kylechar, 2016-10-06 23:42:41]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR= dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[kylechar, 2016-10-06 23:43:16]

Adding TBR for dtrainor@chromium.org and fsamuel@chromium.org

[kylechar, 2016-10-06 23:43:26]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-10-06 23:43:28]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
aelias@chromium.org, boliu@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2374183006/#ps210001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-10-06 23:44:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:51:45]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-06 23:51:50]

Committed patchset #8 (id:210001)

[commit-bot: I haz the power, 2016-10-06 23:54:49]

Description was changed from

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove GLFrameData from CompositorFrame.

Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.

BUG=651851
TBR=dtrainor@chromium.org,fsamuel@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/5344b39e46eb35c82e09b6fabc5447dbf68ff393
Cr-Commit-Position: refs/heads/master@{#423746}
==========

[commit-bot: I haz the power, 2016-10-06 23:54:50]

Patchset 8 (id:??) landed as
https://crrev.com/5344b39e46eb35c82e09b6fabc5447dbf68ff393
Cr-Commit-Position: refs/heads/master@{#423746}