Issue 2373963002: Support display:flex for 'summary'

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-09-28 08:05:39 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/1

4 years, 2 months ago (2016-09-28 08:05:55 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-09-28 08:05:56 UTC) #3

commit-bot: I haz the power

Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...

4 years, 2 months ago (2016-09-28 08:05:57 UTC) #4

xing.xu

Description was changed from ========== Support display:flex for 'summary' BUG=635284 ========== to ========== Support display:flex ...

4 years, 2 months ago (2016-09-28 08:51:26 UTC) #5

xing.xu

xing.xu@intel.com changed reviewers: + cbiesinger@chromium.org, skobes@chromium.org

4 years, 2 months ago (2016-09-28 11:02:52 UTC) #7

cbiesinger

Description was changed from ========== Support display:flex for 'summary' BUG=635284 R=skobes@chromium.org, cbiesinger@chromium.org ========== to ========== ...

4 years, 2 months ago (2016-09-28 11:04:22 UTC) #9

cbiesinger

Thank you very much for working on this! A few comments below. I also updated ...

4 years, 2 months ago (2016-09-28 11:16:09 UTC) #10

xing.xu

Thanks. Refined, please help to review. BTW, should add test case for (INLINE_FLEX, INLINE_GRID) ? ...

4 years, 2 months ago (2016-09-28 14:25:12 UTC) #11

cbiesinger

Please do add a display: grid testcase. Perhaps a simple inline-flex and inline-grid testcase as ...

4 years, 2 months ago (2016-09-28 16:51:11 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/40001

4 years, 2 months ago (2016-10-03 15:23:20 UTC) #16

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-03 15:32:31 UTC) #17

commit-bot: I haz the power

Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/209735) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...

4 years, 2 months ago (2016-10-03 15:32:32 UTC) #18

cbiesinger

Looks like https://codereview.chromium.org/2370673002 changed how display works... have to use EDisplay::Flex, EDisplay::InlineFlex etc. now

4 years, 2 months ago (2016-10-03 15:35:54 UTC) #19

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-03 23:48:05 UTC) #20

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/60001

4 years, 2 months ago (2016-10-03 23:49:06 UTC) #21

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 00:00:10 UTC) #22

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/138938) chromium_presubmit on ...

4 years, 2 months ago (2016-10-04 00:00:11 UTC) #23

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 05:39:29 UTC) #24

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/80001

4 years, 2 months ago (2016-10-04 05:39:35 UTC) #25

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 05:48:51 UTC) #26

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272822)

4 years, 2 months ago (2016-10-04 05:48:52 UTC) #27

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 06:10:42 UTC) #28

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/100001

4 years, 2 months ago (2016-10-04 06:10:50 UTC) #29

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 06:19:05 UTC) #30

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272842)

4 years, 2 months ago (2016-10-04 06:19:05 UTC) #31

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 06:38:52 UTC) #32

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/120001

4 years, 2 months ago (2016-10-04 06:39:05 UTC) #33

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 06:48:16 UTC) #34

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272859)

4 years, 2 months ago (2016-10-04 06:48:16 UTC) #35

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 08:10:51 UTC) #36

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/140001

4 years, 2 months ago (2016-10-04 08:11:08 UTC) #37

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 08:19:47 UTC) #38

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272889)

4 years, 2 months ago (2016-10-04 08:19:49 UTC) #39

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 09:17:11 UTC) #40

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/160001

4 years, 2 months ago (2016-10-04 09:17:26 UTC) #41

xing.xu

The patchset sent to the CQ was uploaded after l-g-t-m from cbiesinger@chromium.org Link to the ...

4 years, 2 months ago (2016-10-04 09:22:23 UTC) #44

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/160001

4 years, 2 months ago (2016-10-04 09:22:39 UTC) #45

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 2 months ago (2016-10-04 09:31:52 UTC) #46

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272921)

4 years, 2 months ago (2016-10-04 09:31:53 UTC) #47

xing.xu

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

4 years, 2 months ago (2016-10-04 14:49:01 UTC) #48

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/200001

4 years, 2 months ago (2016-10-04 14:49:22 UTC) #49

xing.xu

The patchset sent to the CQ was uploaded after l-g-t-m from cbiesinger@chromium.org Link to the ...

4 years, 2 months ago (2016-10-04 23:47:45 UTC) #52

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373963002/200001

4 years, 2 months ago (2016-10-04 23:48:09 UTC) #53

commit-bot: I haz the power

Description was changed from ========== Support display:flex for 'summary' BUG=603928 R=skobes@chromium.org, cbiesinger@chromium.org ========== to ========== ...

4 years, 2 months ago (2016-10-04 23:54:17 UTC) #54

commit-bot: I haz the power

Description was changed from ========== Support display:flex for 'summary' BUG=603928 R=skobes@chromium.org, cbiesinger@chromium.org ========== to ========== ...

4 years, 2 months ago (2016-10-04 23:58:30 UTC) #56

commit-bot: I haz the power

4 years, 2 months ago (2016-10-04 23:58:31 UTC) #57

Message was sent while issue was closed.

Patchset 11 (id:??) landed as
https://crrev.com/b711bbea21e196179a525c1588004ca4f60d025d
Cr-Commit-Position: refs/heads/master@{#423008}

Issue 2373963002: Support display:flex for 'summary' (Closed)

Description

Patch Set 1 #

Patch Set 2 : Support flex for 'summary' #

Patch Set 3 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 4 : Support flex for 'summary' #

Patch Set 5 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 6 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 7 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 8 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 9 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 10 : Support display flex/inline-flex/grid/inline-grid for summary #

Patch Set 11 : Support display flex/inline-flex/grid/inline-grid for summary #

Messages