third_party/WebKit/LayoutTests/fast/html/summary-flexbox-expected.txt - Issue 2373963002: Support display:flex for 'summary'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/html/summary-flexbox-expected.txt

Issue 2373963002: Support display:flex for 'summary' (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 layer at (0,0) size 800x600
	cbiesinger 2016/09/28 11:16:09 For new tests, it is better to write them as refte For new tests, it is better to write them as reftests (or js tests), because with image tests you have the problem that different platforms have different font rendering etc. So, you would need a different PNG for each platform. While possible, that's annoying. Instead, you can write a reftest: https://trac.webkit.org/wiki/Writing%20Reftests In this case, you could, for example, specify flex-direction: column on the summary element, and in the -expected file you can insert linebreaks to checl that it is displayed vertically. Perhaps look at the tests in this change for inspiration: https://codereview.chromium.org/2215133005
	2 LayoutView at (0,0) size 800x600

	3 layer at (0,0) size 800x600

	4 LayoutBlockFlow {HTML} at (0,0) size 800x600

	5 LayoutBlockFlow {BODY} at (8,8) size 784x584

	6 LayoutBlockFlow {DETAILS} at (0,0) size 784x20

	7 LayoutFlexibleBox {SUMMARY} at (0,0) size 784x20

	8 LayoutDetailsMarker {DIV} at (0,0) size 10.55x10.55: right

	9 LayoutBlockFlow {SPAN} at (16.94,0) size 25x20

	10 LayoutText {#text} at (0,0) size 25x19

	11 text run at (0,0) width 25: "hola"

	12 LayoutBlockFlow {SPAN} at (41.94,0) size 22x20

	13 LayoutText {#text} at (0,0) size 22x19

	14 text run at (0,0) width 22: "qu\x{E9}"

	15 LayoutBlockFlow {SPAN} at (63.94,0) size 21x20

	16 LayoutText {#text} at (0,0) size 21x19

	17 text run at (0,0) width 21: "tal?"

OLD	NEW