Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 11cd76855e29238678c673c8345ecd41d18fc84f..79a38f8ac20cb52b9d87771c056e32ea4e8be1e2 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -242,8 +242,7 @@ class RequestCoordinatorTest
std::vector<std::unique_ptr<SavePageRequest>> requests);
// Callback for removing requests.
- void RemoveRequestsDone(
- const RequestQueue::UpdateMultipleRequestResults& results);
+ void RemoveRequestsDone(const MultipleItemStatuses& results);
// Callback for getting request statuses.
void GetQueuedRequestsDone(
@@ -260,8 +259,7 @@ class RequestCoordinatorTest
return last_requests_;
}
- const RequestQueue::UpdateMultipleRequestResults& last_remove_results()
- const {
+ const MultipleItemStatuses& last_remove_results() const {
return last_remove_results_;
}
@@ -314,7 +312,7 @@ class RequestCoordinatorTest
private:
RequestQueue::GetRequestsResult last_get_requests_result_;
- RequestQueue::UpdateMultipleRequestResults last_remove_results_;
+ MultipleItemStatuses last_remove_results_;
std::vector<std::unique_ptr<SavePageRequest>> last_requests_;
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
base::ThreadTaskRunnerHandle task_runner_handle_;
@@ -368,7 +366,7 @@ void RequestCoordinatorTest::GetRequestsDone(
}
void RequestCoordinatorTest::RemoveRequestsDone(
- const RequestQueue::UpdateMultipleRequestResults& results) {
+ const MultipleItemStatuses& results) {
last_remove_results_ = results;
waiter_.Signal();
}
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_picker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698