Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Side by Side Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 235
236 // Callback for Add requests. 236 // Callback for Add requests.
237 void AddRequestDone(RequestQueue::AddRequestResult result, 237 void AddRequestDone(RequestQueue::AddRequestResult result,
238 const SavePageRequest& request); 238 const SavePageRequest& request);
239 239
240 // Callback for getting requests. 240 // Callback for getting requests.
241 void GetRequestsDone(RequestQueue::GetRequestsResult result, 241 void GetRequestsDone(RequestQueue::GetRequestsResult result,
242 std::vector<std::unique_ptr<SavePageRequest>> requests); 242 std::vector<std::unique_ptr<SavePageRequest>> requests);
243 243
244 // Callback for removing requests. 244 // Callback for removing requests.
245 void RemoveRequestsDone( 245 void RemoveRequestsDone(const MultipleItemStatuses& results);
246 const RequestQueue::UpdateMultipleRequestResults& results);
247 246
248 // Callback for getting request statuses. 247 // Callback for getting request statuses.
249 void GetQueuedRequestsDone( 248 void GetQueuedRequestsDone(
250 std::vector<std::unique_ptr<SavePageRequest>> requests); 249 std::vector<std::unique_ptr<SavePageRequest>> requests);
251 250
252 void SendOfflinerDoneCallback(const SavePageRequest& request, 251 void SendOfflinerDoneCallback(const SavePageRequest& request,
253 Offliner::RequestStatus status); 252 Offliner::RequestStatus status);
254 253
255 RequestQueue::GetRequestsResult last_get_requests_result() const { 254 RequestQueue::GetRequestsResult last_get_requests_result() const {
256 return last_get_requests_result_; 255 return last_get_requests_result_;
257 } 256 }
258 257
259 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const { 258 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const {
260 return last_requests_; 259 return last_requests_;
261 } 260 }
262 261
263 const RequestQueue::UpdateMultipleRequestResults& last_remove_results() 262 const MultipleItemStatuses& last_remove_results() const {
264 const {
265 return last_remove_results_; 263 return last_remove_results_;
266 } 264 }
267 265
268 void DisableLoading() { 266 void DisableLoading() {
269 offliner_->disable_loading(); 267 offliner_->disable_loading();
270 } 268 }
271 269
272 void EnableOfflinerCallback(bool enable) { 270 void EnableOfflinerCallback(bool enable) {
273 offliner_->enable_callback(enable); 271 offliner_->enable_callback(enable);
274 } 272 }
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 Offliner::RequestStatus last_offlining_status() const { 305 Offliner::RequestStatus last_offlining_status() const {
308 return coordinator_->last_offlining_status_; 306 return coordinator_->last_offlining_status_;
309 } 307 }
310 308
311 bool OfflinerWasCanceled() const { return offliner_->cancel_called(); } 309 bool OfflinerWasCanceled() const { return offliner_->cancel_called(); }
312 310
313 ObserverStub observer() { return observer_; } 311 ObserverStub observer() { return observer_; }
314 312
315 private: 313 private:
316 RequestQueue::GetRequestsResult last_get_requests_result_; 314 RequestQueue::GetRequestsResult last_get_requests_result_;
317 RequestQueue::UpdateMultipleRequestResults last_remove_results_; 315 MultipleItemStatuses last_remove_results_;
318 std::vector<std::unique_ptr<SavePageRequest>> last_requests_; 316 std::vector<std::unique_ptr<SavePageRequest>> last_requests_;
319 scoped_refptr<base::TestMockTimeTaskRunner> task_runner_; 317 scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
320 base::ThreadTaskRunnerHandle task_runner_handle_; 318 base::ThreadTaskRunnerHandle task_runner_handle_;
321 std::unique_ptr<NetworkQualityEstimatorStub> network_quality_estimator_; 319 std::unique_ptr<NetworkQualityEstimatorStub> network_quality_estimator_;
322 std::unique_ptr<RequestCoordinator> coordinator_; 320 std::unique_ptr<RequestCoordinator> coordinator_;
323 OfflinerStub* offliner_; 321 OfflinerStub* offliner_;
324 base::WaitableEvent waiter_; 322 base::WaitableEvent waiter_;
325 ObserverStub observer_; 323 ObserverStub observer_;
326 }; 324 };
327 325
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 } 359 }
362 360
363 void RequestCoordinatorTest::GetRequestsDone( 361 void RequestCoordinatorTest::GetRequestsDone(
364 RequestQueue::GetRequestsResult result, 362 RequestQueue::GetRequestsResult result,
365 std::vector<std::unique_ptr<SavePageRequest>> requests) { 363 std::vector<std::unique_ptr<SavePageRequest>> requests) {
366 last_get_requests_result_ = result; 364 last_get_requests_result_ = result;
367 last_requests_ = std::move(requests); 365 last_requests_ = std::move(requests);
368 } 366 }
369 367
370 void RequestCoordinatorTest::RemoveRequestsDone( 368 void RequestCoordinatorTest::RemoveRequestsDone(
371 const RequestQueue::UpdateMultipleRequestResults& results) { 369 const MultipleItemStatuses& results) {
372 last_remove_results_ = results; 370 last_remove_results_ = results;
373 waiter_.Signal(); 371 waiter_.Signal();
374 } 372 }
375 373
376 void RequestCoordinatorTest::GetQueuedRequestsDone( 374 void RequestCoordinatorTest::GetQueuedRequestsDone(
377 std::vector<std::unique_ptr<SavePageRequest>> requests) { 375 std::vector<std::unique_ptr<SavePageRequest>> requests) {
378 last_requests_ = std::move(requests); 376 last_requests_ = std::move(requests);
379 waiter_.Signal(); 377 waiter_.Signal();
380 } 378 }
381 379
(...skipping 714 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 // Now whether processing triggered immediately depends on whether test 1094 // Now whether processing triggered immediately depends on whether test
1097 // is run on svelte device or not. 1095 // is run on svelte device or not.
1098 if (base::SysInfo::IsLowEndDevice()) { 1096 if (base::SysInfo::IsLowEndDevice()) {
1099 EXPECT_FALSE(is_busy()); 1097 EXPECT_FALSE(is_busy());
1100 } else { 1098 } else {
1101 EXPECT_TRUE(is_busy()); 1099 EXPECT_TRUE(is_busy());
1102 } 1100 }
1103 } 1101 }
1104 1102
1105 } // namespace offline_pages 1103 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_picker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698