components/offline_pages/background/request_picker.h - Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_picker.h

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)

Patch Set: Addressing final feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_picker.h

diff --git a/components/offline_pages/background/request_picker.h b/components/offline_pages/background/request_picker.h

index 0c8dcb7b6f0e0fd46c6d5e39255a25b660d3fa46..0f80dd7b2ed8c9e3df0a6d479a78931d9425efde 100644

--- a/components/offline_pages/background/request_picker.h

+++ b/components/offline_pages/background/request_picker.h

@@ -78,9 +78,7 @@ class RequestPicker {

std::vector<std::unique_ptr<SavePageRequest>>* expired_requests);

// Callback used after requests get expired.

- void OnRequestExpired(

- const RequestQueue::UpdateMultipleRequestResults& results,

- const std::vector<std::unique_ptr<SavePageRequest>> requests);

+ void OnRequestExpired(std::unique_ptr<UpdateRequestsResult> result);

// Unowned pointer to the request queue.

RequestQueue* queue_;