[tracing] Navigate to parent node in heap dump UI upon pressing backspace

[tracing] Navigate to parent node in heap dump UI upon pressing backspace

As a result of this patch, it will be possible to navigate to the parent
row (e.g. a/b) of the currently displayed row (e.g. a/b/c) in the
breakdown view (right sub-pane) of the "Heap details" UI by pressing
backspace.

BUG=catapult:#2750

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d0e3e41d7aa818fc739c0f25bc1240d0a308898c

[petrcermak, 2016-09-28 17:18:16]

petrcermak@chromium.org changed reviewers:
+ primiano@chromium.org

[petrcermak, 2016-09-28 17:18:16]

PTAL.

Thanks,
Petr

[petrcermak, 2016-10-03 07:37:07]

petrcermak@chromium.org changed reviewers:
+ hjd@chromium.org

[petrcermak, 2016-10-03 07:37:07]

hjd: PTAL.

Thanks,
Petr

[hjd, 2016-10-03 09:33:21]

lgtm

https://codereview.chromium.org/2373913003/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_heap_details_path_view.html
(right):

https://codereview.chromium.org/2373913003/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_heap_details_path_view.html:108: if
(this.$.table.tableRows.indexOf(this.selectedNode_) !== -1) {
this.$.table.tableRows.includes(this.selectedNode_) might read a tiny bit easier

[petrcermak, 2016-10-03 09:40:25]

Thanks for your comment.

https://codereview.chromium.org/2373913003/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_heap_details_path_view.html
(right):

https://codereview.chromium.org/2373913003/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_heap_details_path_view.html:108: if
(this.$.table.tableRows.indexOf(this.selectedNode_) !== -1) {
On 2016/10/03 09:33:21, hjd wrote:
> this.$.table.tableRows.includes(this.selectedNode_) might read a tiny bit
easier

Done. I was not aware of that method :-)

[petrcermak, 2016-10-03 09:40:32]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-10-03 09:40:32]

The patchset sent to the CQ was uploaded after l-g-t-m from hjd@chromium.org
Link to the patchset: https://codereview.chromium.org/2373913003/#ps20001
(title: "Use Array.prototype.includes")

[commit-bot: I haz the power, 2016-10-03 09:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 10:05:23]

Description was changed from

==========
[tracing] Navigate to parent node in heap dump UI upon pressing backspace

As a result of this patch, it will be possible to navigate to the parent
row (e.g. a/b) of the currently displayed row (e.g. a/b/c) in the
breakdown view (right sub-pane) of the "Heap details" UI by pressing
backspace.

BUG=catapult:#2750
==========

to

==========
[tracing] Navigate to parent node in heap dump UI upon pressing backspace

As a result of this patch, it will be possible to navigate to the parent
row (e.g. a/b) of the currently displayed row (e.g. a/b/c) in the
breakdown view (right sub-pane) of the "Heap details" UI by pressing
backspace.

BUG=catapult:#2750

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-03 10:05:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...