Chromium Code Reviews Chromium Code Reviews
Issue 2373913003:
[tracing] Navigate to parent node in heap dump UI upon pressing backspace (Closed)
Base URL: git@github.com:catapult-project/catapult.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright 2016 The Chromium Authors. All rights reserved. | 3 Copyright 2016 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <link rel="import" href="/tracing/base/color_scheme.html"> | 8 <link rel="import" href="/tracing/base/color_scheme.html"> |
| 9 <link rel="import" href="/tracing/base/event.html"> | 9 <link rel="import" href="/tracing/base/event.html"> |
| 10 <link rel="import" href="/tracing/ui/analysis/memory_dump_heap_details_util.html "> | 10 <link rel="import" href="/tracing/ui/analysis/memory_dump_heap_details_util.html "> |
| (...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 98 this.aggregationMode_ = aggregationMode; | 98 this.aggregationMode_ = aggregationMode; |
| 99 this.scheduleRebuild_(); | 99 this.scheduleRebuild_(); |
| 100 }, | 100 }, |
| 101 | 101 |
| 102 onRebuild_: function() { | 102 onRebuild_: function() { |
| 103 if (this.selectedNode_ === undefined) { | 103 if (this.selectedNode_ === undefined) { |
| 104 this.$.table.clear(); | 104 this.$.table.clear(); |
| 105 return; | 105 return; |
| 106 } | 106 } |
| 107 | 107 |
| 108 if (this.$.table.tableRows.indexOf(this.selectedNode_) !== -1) { | |
|
hjd
2016/10/03 09:33:21
this.$.table.tableRows.includes(this.selectedNode_
petrcermak
2016/10/03 09:40:25
Done. I was not aware of that method :-)
| |
| 109 this.$.table.selectedTableRow = this.selectedNode_; | |
| 110 return; | |
| 111 } | |
| 112 | |
| 108 this.$.table.selectionMode = tr.ui.b.TableFormat.SelectionMode.ROW; | 113 this.$.table.selectionMode = tr.ui.b.TableFormat.SelectionMode.ROW; |
| 109 this.$.table.userCanModifySortOrder = false; | 114 this.$.table.userCanModifySortOrder = false; |
| 110 var rows = this.createRows_(this.selectedNode_); | 115 var rows = this.createRows_(this.selectedNode_); |
| 111 this.$.table.tableRows = rows; | 116 this.$.table.tableRows = rows; |
| 112 this.$.table.tableColumns = this.createColumns_(rows); | 117 this.$.table.tableColumns = this.createColumns_(rows); |
| 113 this.$.table.selectedTableRow = rows[rows.length - 1]; | 118 this.$.table.selectedTableRow = rows[rows.length - 1]; |
| 114 }, | 119 }, |
| 115 | 120 |
| 116 createRows_: function(node) { | 121 createRows_: function(node) { |
| 117 var rows = []; | 122 var rows = []; |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 135 }); | 140 }); |
| 136 tr.ui.analysis.MemoryColumn.spaceEqually(numericColumns); | 141 tr.ui.analysis.MemoryColumn.spaceEqually(numericColumns); |
| 137 | 142 |
| 138 return [titleColumn].concat(numericColumns); | 143 return [titleColumn].concat(numericColumns); |
| 139 } | 144 } |
| 140 }); | 145 }); |
| 141 | 146 |
| 142 return {}; | 147 return {}; |
| 143 }); | 148 }); |
| 144 </script> | 149 </script> |
| OLD | NEW |
