Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2373853002: Allow targets to use BuildConfig by simply depending on base_java (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
michaelbai, nyquist
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org, estevenson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow targets to use BuildConfig by simply depending on base_java BUG=650779 TBR=nyquist Committed: https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa Cr-Commit-Position: refs/heads/master@{#421516}

Patch Set 1 #

Patch Set 2 : fix compile error when interface jar doesn't match proguarded jar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M android_webview/glue/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 chunks +27 lines, -8 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
agrieve
michaelbai@chromium.org: Please review changes in everywhere nyquist@chromium.org: Please review changes in testing/android
4 years, 2 months ago (2016-09-28 00:40:26 UTC) #6
michaelbai
lgtm
4 years, 2 months ago (2016-09-28 02:49:06 UTC) #11
agrieve
On 2016/09/28 02:49:06, michaelbai wrote: > lgtm tbr nyquist@ for testing/android/ (trivial) part
4 years, 2 months ago (2016-09-28 14:13:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373853002/20001
4 years, 2 months ago (2016-09-28 14:13:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 14:18:39 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa Cr-Commit-Position: refs/heads/master@{#421516}
4 years, 2 months ago (2016-09-28 14:20:34 UTC) #19
nyquist
4 years, 2 months ago (2016-09-28 14:31:37 UTC) #20
Message was sent while issue was closed.
testing/android lgtm

Powered by Google App Engine
This is Rietveld 408576698