Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2373853002: Allow targets to use BuildConfig by simply depending on base_java (Closed)
Patch Set: fix compile error when interface jar doesn't match proguarded jar Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/glue/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 1809 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 } 1820 }
1821 1821
1822 build_config = _build_config 1822 build_config = _build_config
1823 input_jar_path = invoker.jar_path 1823 input_jar_path = invoker.jar_path
1824 output_jar_path = _jar_path 1824 output_jar_path = _jar_path
1825 1825
1826 deps = [ ":$_build_config_target_name" ] + _deps + _jar_deps 1826 deps = [ ":$_build_config_target_name" ] + _deps + _jar_deps
1827 } 1827 }
1828 1828
1829 generate_interface_jar(_ijar_target_name) { 1829 generate_interface_jar(_ijar_target_name) {
1830 input_jar = _jar_path 1830 if (!defined(invoker.proguard_preprocess) ||
1831 !invoker.proguard_preprocess) {
1832 # Always used the unfiltered .jar to create the interface jar so that
1833 # other targets will resolve filtered classes when depending on
1834 # BuildConfig, NativeLibraries, etc.
1835 input_jar = invoker.jar_path
1836 deps = _deps + _jar_deps
1837 } else {
1838 # However, still apply pre-proguarding, since ignoring that can break
1839 # compiles.
1840 input_jar = _jar_path
1841 deps = [
1842 ":$_process_jar_target_name",
1843 ]
1844 }
1845
1831 output_jar = _ijar_path 1846 output_jar = _ijar_path
1832 deps = [
1833 ":$_process_jar_target_name",
1834 ]
1835 } 1847 }
1836 1848
1837 if (_supports_android) { 1849 if (_supports_android) {
1838 dex(_dex_target_name) { 1850 dex(_dex_target_name) {
1839 sources = [ 1851 sources = [
1840 _jar_path, 1852 _jar_path,
1841 ] 1853 ]
1842 output = _dex_path 1854 output = _dex_path
1843 deps = [ ":$_process_jar_target_name" ] + _deps + _jar_deps 1855 deps = [ ":$_process_jar_target_name" ] + _deps + _jar_deps
1844 } 1856 }
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
2121 input_jar_path = _process_prebuilt_jar_path 2133 input_jar_path = _process_prebuilt_jar_path
2122 output_jar_path = _final_jar_path 2134 output_jar_path = _final_jar_path
2123 2135
2124 deps = [ 2136 deps = [
2125 ":$_process_prebuilt_target_name", 2137 ":$_process_prebuilt_target_name",
2126 ] 2138 ]
2127 } 2139 }
2128 } 2140 }
2129 2141
2130 generate_interface_jar(_ijar_target_name) { 2142 generate_interface_jar(_ijar_target_name) {
2131 input_jar = _final_jar_path 2143 if (!defined(invoker.proguard_preprocess) ||
2132 output_jar = _final_ijar_path 2144 !invoker.proguard_preprocess) {
2133 if (_emma_instrument) { 2145 # Always used the unfiltered .jar to create the interface jar so that
2146 # other targets will resolve filtered classes when depending on
2147 # BuildConfig, NativeLibraries, etc.
2148 input_jar = _javac_jar_path
2134 deps = [ 2149 deps = [
2135 ":$_emma_instr_target_name", 2150 ":$_javac_target_name",
2136 ] 2151 ]
2137 } else { 2152 } else {
2153 # However, still apply pre-proguarding, since ignoring that can break
2154 # compiles.
2155 input_jar = _process_prebuilt_jar_path
2138 deps = [ 2156 deps = [
2139 ":$_process_prebuilt_target_name", 2157 ":$_process_prebuilt_target_name",
2140 ] 2158 ]
2141 } 2159 }
2160 output_jar = _final_ijar_path
2142 } 2161 }
2143 2162
2144 group(_final_target_name) { 2163 group(_final_target_name) {
2145 forward_variables_from(invoker, [ "visibility" ]) 2164 forward_variables_from(invoker, [ "visibility" ])
2146 public_deps = [ 2165 public_deps = [
2147 ":$_ijar_target_name", 2166 ":$_ijar_target_name",
2148 ] 2167 ]
2149 if (_emma_instrument) { 2168 if (_emma_instrument) {
2150 public_deps += [ ":$_emma_instr_target_name" ] 2169 public_deps += [ ":$_emma_instr_target_name" ]
2151 } else { 2170 } else {
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
2692 rebase_path(root_build_dir, root_build_dir), 2711 rebase_path(root_build_dir, root_build_dir),
2693 "--packed-libraries-dir", 2712 "--packed-libraries-dir",
2694 rebase_path(_packed_libraries_dir, root_build_dir), 2713 rebase_path(_packed_libraries_dir, root_build_dir),
2695 "--libraries=${invoker.libraries_filearg}", 2714 "--libraries=${invoker.libraries_filearg}",
2696 "--filelistjson", 2715 "--filelistjson",
2697 rebase_path(invoker.file_list_json, root_build_dir), 2716 rebase_path(invoker.file_list_json, root_build_dir),
2698 ] 2717 ]
2699 } 2718 }
2700 } 2719 }
2701 } 2720 }
OLDNEW
« no previous file with comments | « android_webview/glue/BUILD.gn ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698