Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: android_webview/glue/BUILD.gn

Issue 2373853002: Allow targets to use BuildConfig by simply depending on base_java (Closed)
Patch Set: fix compile error when interface jar doesn't match proguarded jar Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/BUILD.gn
diff --git a/android_webview/glue/BUILD.gn b/android_webview/glue/BUILD.gn
index 4347ccdfbb747a72bad671608dbfd8e70b0a46b8..ab529541f9bea2fb520611dfe410dde18fc18fa7 100644
--- a/android_webview/glue/BUILD.gn
+++ b/android_webview/glue/BUILD.gn
@@ -41,13 +41,7 @@ generate_resource_rewriter("glue_resource_rewriter") {
android_library("glue") {
# Change deps? please modify glue_library_deps variable.
deps = glue_library_deps
- srcjar_deps = [
- ":glue_resource_rewriter",
- "//base:base_build_config_gen",
- ]
-
- # New versions of BuildConfig.java will be created when creating an apk.
- jar_excluded_patterns = [ "*/BuildConfig.class" ]
+ srcjar_deps = [ ":glue_resource_rewriter" ]
# Always build upstream or downstream target with public or internal
# framework jar respectively.
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698