Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2373013002: [typedarray] Really check that the JSTypedArray::length is always a Smi. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[typedarray] Really check that the JSTypedArray::length is always a Smi. Even after https://codereview.chromium.org/2371963002 we might still create JSTypedArray instances where the length field is a HeapNumber, especially when TurboFan no longer canonicalizes all values in Smi range to Smis (which we try to achieve currently). This adds strict checking for this fact now. R=mstarzinger@chromium.org Committed: https://crrev.com/bda4774c373738cf7489065d0240f1bc44436176 Cr-Commit-Position: refs/heads/master@{#39771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/objects-debug.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
4 years, 2 months ago (2016-09-27 12:55:30 UTC) #1
Michael Starzinger
LGTM.
4 years, 2 months ago (2016-09-27 12:58:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373013002/1
4 years, 2 months ago (2016-09-27 13:09:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 13:23:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 13:23:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bda4774c373738cf7489065d0240f1bc44436176
Cr-Commit-Position: refs/heads/master@{#39771}

Powered by Google App Engine
This is Rietveld 408576698