src/runtime/runtime-typedarray.cc - Issue 2373013002: [typedarray] Really check that the JSTypedArray::length is always a Smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-typedarray.cc

Issue 2373013002: [typedarray] Really check that the JSTypedArray::length is always a Smi. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-typedarray.cc

diff --git a/src/runtime/runtime-typedarray.cc b/src/runtime/runtime-typedarray.cc

index 80d57bc3f2d11c5cb64573db9852b31e4d549e9e..963f1862bc7b965d77bb7a3733541500d7f7bf01 100644

--- a/src/runtime/runtime-typedarray.cc

+++ b/src/runtime/runtime-typedarray.cc

@@ -204,6 +204,7 @@ RUNTIME_FUNCTION(Runtime_TypedArrayInitializeFromArrayLike) {

length = JSTypedArray::cast(*source)->length_value();

} else {

CHECK(TryNumberToSize(*length_obj, &length));

+ CHECK(length_obj->IsSmi());

}

if ((length > static_cast<unsigned>(Smi::kMaxValue)) ||

« no previous file with comments | « src/objects-debug.cc ('k') | no next file » | no next file with comments »