Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3402)

Unified Diff: components/browser_watcher/watcher_metrics_provider_win.h

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Direct access to GetExecutableVersionDetails via ChromePostmortemReportCollector Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/watcher_metrics_provider_win.h
diff --git a/components/browser_watcher/watcher_metrics_provider_win.h b/components/browser_watcher/watcher_metrics_provider_win.h
index 944e17df02ed5d1a90cea73c86c94bde9eabc198..ca2c6b1610cdf4624340e2f8d111662ad30eec6d 100644
--- a/components/browser_watcher/watcher_metrics_provider_win.h
+++ b/components/browser_watcher/watcher_metrics_provider_win.h
@@ -5,12 +5,15 @@
#ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
#define COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
+#include <memory>
+
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "base/task_runner.h"
#include "base/threading/thread_checker.h"
+#include "components/browser_watcher/postmortem_report_collector.h"
#include "components/metrics/metrics_provider.h"
namespace browser_watcher {
@@ -24,10 +27,12 @@ class WatcherMetricsProviderWin : public metrics::MetricsProvider {
// Initializes the reporter. |io_task_runner| is used for collecting
// postmortem reports and clearing leftover data in registry if metrics
// reporting is disabled.
- WatcherMetricsProviderWin(const base::string16& registry_path,
- const base::FilePath& user_data_dir,
- const base::FilePath& crash_dir,
- base::TaskRunner* io_task_runner);
+ WatcherMetricsProviderWin(
+ const base::string16& registry_path,
+ const base::FilePath& user_data_dir,
+ const base::FilePath& crash_dir,
+ std::unique_ptr<PostmortemReportCollector> collector,
+ base::TaskRunner* io_task_runner);
~WatcherMetricsProviderWin() override;
// metrics::MetricsProvider implementation.
@@ -60,6 +65,7 @@ class WatcherMetricsProviderWin : public metrics::MetricsProvider {
const base::string16 registry_path_;
const base::FilePath user_data_dir_;
const base::FilePath crash_dir_;
+ std::unique_ptr<PostmortemReportCollector> collector_;
scoped_refptr<base::TaskRunner> io_task_runner_;
base::WeakPtrFactory<WatcherMetricsProviderWin> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698