Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6001)

Unified Diff: chrome/chrome_watcher/chrome_postmortem_report_collector.h

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Direct access to GetExecutableVersionDetails via ChromePostmortemReportCollector Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_watcher/chrome_postmortem_report_collector.h
diff --git a/chrome/chrome_watcher/chrome_postmortem_report_collector.h b/chrome/chrome_watcher/chrome_postmortem_report_collector.h
new file mode 100644
index 0000000000000000000000000000000000000000..c05c1044949da9d3637e45cb2fbb0566cc8a6549
--- /dev/null
+++ b/chrome/chrome_watcher/chrome_postmortem_report_collector.h
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_CHROME_WATCHER_CHROME_POSTMORTEM_REPORT_COLLECTOR_H_
+#define CHROME_CHROME_WATCHER_CHROME_POSTMORTEM_REPORT_COLLECTOR_H_
+
+#include <string>
+
+#include "components/browser_watcher/postmortem_report_collector.h"
+
+namespace chrome_watcher {
+
+class ChromePostmortemReportCollector
+ : public browser_watcher::PostmortemReportCollector {
+ public:
+ ChromePostmortemReportCollector();
+ ~ChromePostmortemReportCollector() override = default;
grt (UTC plus 2) 2016/09/27 20:43:09 is this needed?
manzagop (departed) 2016/09/28 16:29:17 Ack.
+
+ const std::string& GetProductName() override;
+ const std::string& GetProductVersion() override;
+ const std::string& GetProductChannel() override;
+
+ private:
+ void InitializeVersionDetails();
+
+ bool version_details_initialized_;
+ std::string product_name_;
+ std::string version_number_;
+ std::string channel_name_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChromePostmortemReportCollector);
+};
+
+} // namespace chrome_watcher
+
+#endif // CHROME_CHROME_WATCHER_CHROME_POSTMORTEM_REPORT_COLLECTOR_H_

Powered by Google App Engine
This is Rietveld 408576698