Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/browser_watcher/postmortem_report_collector_unittest.cc

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Direct access to GetExecutableVersionDetails via ChromePostmortemReportCollector Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_report_collector_unittest.cc
diff --git a/components/browser_watcher/postmortem_report_collector_unittest.cc b/components/browser_watcher/postmortem_report_collector_unittest.cc
index c717e10c5875f4b5089d256885a3de7a1b703da3..2aa96bc9c0926a39ab818ea591ee63f4708f572f 100644
--- a/components/browser_watcher/postmortem_report_collector_unittest.cc
+++ b/components/browser_watcher/postmortem_report_collector_unittest.cc
@@ -100,6 +100,9 @@ class MockPostmortemReportCollector : public PostmortemReportCollector {
return SUCCESS;
}
+ MOCK_METHOD0(GetProductName, const std::string&());
+ MOCK_METHOD0(GetProductVersion, const std::string&());
+ MOCK_METHOD0(GetProductChannel, const std::string&());
MOCK_METHOD3(GetDebugStateFilePaths,
std::vector<base::FilePath>(
const base::FilePath& debug_info_dir,
@@ -132,6 +135,27 @@ MATCHER_P(EqualsProto, message, "") {
return expected_serialized == actual_serialized;
}
+class PostmortemReportCollectorForTest : public PostmortemReportCollector {
+ public:
+ PostmortemReportCollectorForTest()
+ : PostmortemReportCollector(),
+ product_name_("TestProduct"),
+ version_number_("TestVersionNumber"),
+ channel_name_("TestChannel") {}
+ ~PostmortemReportCollectorForTest() override = default;
+
+ const std::string& GetProductName() override { return product_name_; }
+ const std::string& GetProductVersion() override { return version_number_; }
+ const std::string& GetProductChannel() override { return channel_name_; }
+
+ private:
+ std::string product_name_;
+ std::string version_number_;
+ std::string channel_name_;
+
+ DISALLOW_COPY_AND_ASSIGN(PostmortemReportCollectorForTest);
+};
+
} // namespace
class PostmortemReportCollectorCollectAndSubmitTest : public testing::Test {
@@ -261,7 +285,7 @@ TEST(PostmortemReportCollectorTest, GetDebugStateFilePaths) {
ASSERT_NE(file.get(), nullptr);
}
- PostmortemReportCollector collector;
+ PostmortemReportCollectorForTest collector;
EXPECT_THAT(
collector.GetDebugStateFilePaths(
temp_dir.path(), FILE_PATH_LITERAL("foo*.pma"), excluded_paths),
@@ -280,7 +304,7 @@ TEST(PostmortemReportCollectorTest, CollectEmptyFile) {
ASSERT_TRUE(PathExists(file_path));
// Validate collection: an empty file cannot suppport an analyzer.
- PostmortemReportCollector collector;
+ PostmortemReportCollectorForTest collector;
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::ANALYZER_CREATION_FAILED,
collector.Collect(file_path, &report));
@@ -305,7 +329,7 @@ TEST(PostmortemReportCollectorTest, CollectRandomFile) {
// Validate collection: random content appears as though there is not
// stability data.
- PostmortemReportCollector collector;
+ PostmortemReportCollectorForTest collector;
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::DEBUG_FILE_NO_DATA,
collector.Collect(file_path, &report));
@@ -399,7 +423,7 @@ class PostmortemReportCollectorCollectionTest : public testing::Test {
TEST_F(PostmortemReportCollectorCollectionTest, CollectSuccess) {
// Validate collection returns the expected report.
- PostmortemReportCollector collector;
+ PostmortemReportCollectorForTest collector;
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::SUCCESS,
collector.Collect(debug_file_path(), &report));

Powered by Google App Engine
This is Rietveld 408576698