Show bootstrap and server bot_code version

Show bootstrap and server bot_code version

BUG=631047
Committed: https://github.com/luci/luci-py/commit/3b1ba7b778122f5958342d6fce222eca85a6e958

[kjlubick, 2016-09-26 18:09:57]

kjlubick@google.com changed reviewers:
+ stephana@google.com

[kjlubick, 2016-09-26 18:09:59]

Live on
https://2365-bd022ad-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/

See:
https://screenshot.googleplex.com/04yrXT3f3rd  (only admins can bootstrap)
https://screenshot.googleplex.com/U002fWoUBb0
https://screenshot.googleplex.com/hCuVyvATyQL

[stephana, 2016-09-26 20:04:12]

https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/index/swarming-index.html (right):

https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/index/swarming-index.html:180: var p =
sk.request("POST", "/_ah/api/swarming/v1/server/token", undefined,
auth_headers);
Shouldn't this also deal with the case when the POST request fails. 
IMO the pattern:

... 
this.set("_busy", true); 
sk.request("POST" ...).then(JSON.parse).then(function(t) {
....
  this.set("_busy", false); 
}.bind(this).catch(function(err) {
  this.set("_busy", false); 
  errorHandler(err);
}.bind(this); 
...

would be preferable.

[kjlubick, 2016-09-27 12:09:31]

https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/index/swarming-index.html (right):

https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/index/swarming-index.html:180: var p =
sk.request("POST", "/_ah/api/swarming/v1/server/token", undefined,
auth_headers);
On 2016/09/26 at 20:04:11, stephana wrote:
> Shouldn't this also deal with the case when the POST request fails. 
> IMO the pattern:
> 
> ... 
> this.set("_busy", true); 
> sk.request("POST" ...).then(JSON.parse).then(function(t) {
> ....
>   this.set("_busy", false); 
> }.bind(this).catch(function(err) {
>   this.set("_busy", false); 
>   errorHandler(err);
> }.bind(this); 
> ...
> 
> would be preferable.

Done.

[stephana, 2016-09-27 15:32:27]

On 2016/09/27 12:09:31, kjlubick wrote:
>
https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
> File appengine/swarming/elements/res/imp/index/swarming-index.html (right):
> 
>
https://codereview.chromium.org/2372553003/diff/1/appengine/swarming/elements...
> appengine/swarming/elements/res/imp/index/swarming-index.html:180: var p =
> sk.request("POST", "/_ah/api/swarming/v1/server/token", undefined,
> auth_headers);
> On 2016/09/26 at 20:04:11, stephana wrote:
> > Shouldn't this also deal with the case when the POST request fails. 
> > IMO the pattern:
> > 
> > ... 
> > this.set("_busy", true); 
> > sk.request("POST" ...).then(JSON.parse).then(function(t) {
> > ....
> >   this.set("_busy", false); 
> > }.bind(this).catch(function(err) {
> >   this.set("_busy", false); 
> >   errorHandler(err);
> > }.bind(this); 
> > ...
> > 
> > would be preferable.
> 
> Done.

lgtm

[KevinL, 2016-09-27 15:36:59]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-27 15:37:00]

lgtm

[kjlubick, 2016-09-27 15:37:15]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-09-27 15:37:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:40:50]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31851cb8550c1f10)

[kjlubick, 2016-09-27 16:25:19]

The CQ bit was checked by kjlubick@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 16:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 16:29:12]

Dry run: Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/318548b37153d910)

[kjlubick, 2016-09-27 16:34:21]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-09-27 16:34:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjlubick@chromium.org, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2372553003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-27 16:34:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:38:08]

Description was changed from

==========
Show bootstrap and server bot_code version

BUG=631047
==========

to

==========
Show bootstrap and server bot_code version

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/3b1ba7b778122f5958342d6fce222eca85a6e958
==========

[commit-bot: I haz the power, 2016-09-27 16:38:10]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/3b1ba7b778122f5958342d6fce222eca85a6e958