Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2367413003: Update Stats element to use new directory layout (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
KevinL, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, jcgregorio, M-A Ruel
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Update Stats element to use new directory layout Also fix the overview element to show data in browser local time instead of UTC. Due to the fact that the stats api doesn't use OAuth, I'm going to hold off on any more stats work until the rest of the new UI is out the door. BUG=631047 Committed: https://github.com/luci/luci-py/commit/74b4d7e30bb7e046653b76cee5d97850a39c8928

Patch Set 1 #

Patch Set 2 : tweak docs #

Patch Set 3 : Add demo data #

Total comments: 3

Patch Set 4 : Typo #

Patch Set 5 : Add todo #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -22 lines) Patch
M appengine/swarming/elements/Makefile View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/swarming/elements/build/elements.html View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/elements/res/imp/index/swarming-index.html View 1 2 3 4 4 chunks +17 lines, -8 lines 0 comments Download
M appengine/swarming/elements/res/imp/index/swarming-index-demo.html View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/stats/load-charts-api.html View 1 chunk +1 line, -1 line 0 comments Download
D appengine/swarming/elements/res/imp/stats/overview-demo.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/stats/partial-line-chart.html View 1 2 chunks +1 line, -2 lines 0 comments Download
M appengine/swarming/elements/res/imp/stats/stats-overview.html View 1 2 3 4 3 chunks +41 lines, -6 lines 0 comments Download
M appengine/swarming/elements/res/imp/stats/stats-overview-demo.html View 2 chunks +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
kjlubick
4 years, 2 months ago (2016-09-26 19:15:38 UTC) #3
stephana
4 years, 2 months ago (2016-09-26 20:03:52 UTC) #4
stephana
https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html File appengine/swarming/elements/res/imp/stats/stats-overview.html (right): https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html#newcode106 appengine/swarming/elements/res/imp/stats/stats-overview.html:106: var table = _response.table; could you modify the backend ...
4 years, 2 months ago (2016-09-26 20:05:46 UTC) #5
kjlubick
https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html File appengine/swarming/elements/res/imp/stats/stats-overview.html (right): https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html#newcode106 appengine/swarming/elements/res/imp/stats/stats-overview.html:106: var table = _response.table; On 2016/09/26 at 20:05:46, stephana ...
4 years, 2 months ago (2016-09-27 12:17:19 UTC) #6
stephana
LGTM https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html File appengine/swarming/elements/res/imp/stats/stats-overview.html (right): https://codereview.chromium.org/2367413003/diff/40001/appengine/swarming/elements/res/imp/stats/stats-overview.html#newcode106 appengine/swarming/elements/res/imp/stats/stats-overview.html:106: var table = _response.table; On 2016/09/27 12:17:18, kjlubick ...
4 years, 2 months ago (2016-09-27 15:33:23 UTC) #7
KevinL
lgtm
4 years, 2 months ago (2016-09-27 15:37:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367413003/100001
4 years, 2 months ago (2016-09-27 16:43:01 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:45:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://github.com/luci/luci-py/commit/74b4d7e30bb7e046653b76cee5d97850a39c8928

Powered by Google App Engine
This is Rietveld 408576698