Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2374463002: Add API for bootstrap and bot_code version (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add API for bootstrap and bot_code version BUG=631047 Committed: https://github.com/luci/luci-py/commit/c3c1c43710c301aab00584dd49a150f56dbfd25c

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 4

Patch Set 3 : Make POST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M appengine/swarming/handlers_endpoints.py View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M appengine/swarming/handlers_endpoints_test.py View 2 chunks +5 lines, -1 line 0 comments Download
M appengine/swarming/swarming_rpcs.py View 1 1 chunk +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2372553003 Patch 1
Issue 2372553003 Patch 20001
Issue 2372553003 Patch 40001

Messages

Total messages: 10 (4 generated)
kjlubick
4 years, 2 months ago (2016-09-26 16:29:38 UTC) #3
M-A Ruel
https://codereview.chromium.org/2374463002/diff/20001/appengine/swarming/handlers_endpoints.py File appengine/swarming/handlers_endpoints.py (right): https://codereview.chromium.org/2374463002/diff/20001/appengine/swarming/handlers_endpoints.py#newcode141 appengine/swarming/handlers_endpoints.py:141: ) FTR, I'm really not a fan of terminating ...
4 years, 2 months ago (2016-09-26 16:36:16 UTC) #4
kjlubick
https://codereview.chromium.org/2374463002/diff/20001/appengine/swarming/handlers_endpoints.py File appengine/swarming/handlers_endpoints.py (right): https://codereview.chromium.org/2374463002/diff/20001/appengine/swarming/handlers_endpoints.py#newcode141 appengine/swarming/handlers_endpoints.py:141: ) On 2016/09/26 at 16:36:15, M-A Ruel wrote: > ...
4 years, 2 months ago (2016-09-26 16:50:38 UTC) #5
M-A Ruel
sorry for the delay, lgtm
4 years, 2 months ago (2016-09-27 13:12:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374463002/40001
4 years, 2 months ago (2016-09-27 13:13:08 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 13:16:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/c3c1c43710c301aab00584dd49a150f56dbfd25c

Powered by Google App Engine
This is Rietveld 408576698