Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: trunk/src/chrome/renderer/extensions/object_backed_native_handler.cc

Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/renderer/extensions/object_backed_native_handler.cc
===================================================================
--- trunk/src/chrome/renderer/extensions/object_backed_native_handler.cc (revision 222150)
+++ trunk/src/chrome/renderer/extensions/object_backed_native_handler.cc (working copy)
@@ -32,7 +32,7 @@
}
v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
- return object_template_.NewHandle(v8::Isolate::GetCurrent())->NewInstance();
+ return object_template_->NewInstance();
}
// static
@@ -68,7 +68,7 @@
v8::External::New(new HandlerFunction(handler_function)));
v8::Handle<v8::FunctionTemplate> function_template =
v8::FunctionTemplate::New(Router, local_data);
- object_template_.NewHandle(isolate)->Set(name.c_str(), function_template);
+ object_template_->Set(name.c_str(), function_template);
router_data_.push_back(UnsafePersistent<v8::Object>(&data));
}

Powered by Google App Engine
This is Rietveld 408576698