Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2372373002: Remove getters that duplicate FunctionKind in SharedFunctionInfo and ParseInfo (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
ulan, neis, jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove getters that duplicate FunctionKind in SharedFunctionInfo and ParseInfo R=neis@chromium.org Committed: https://crrev.com/622bb78d9b3b92fd384b3867acd30de1cecba5d2 Cr-Commit-Position: refs/heads/master@{#39842}

Patch Set 1 #

Patch Set 2 : Remove SharedFunctionInfo::is_resumable and FunctionState stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -106 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +1 line, -26 lines 0 comments Download
M src/objects.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +1 line, -17 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parse-info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/parsing/parser.cc View 1 4 chunks +9 lines, -12 lines 0 comments Download
M src/parsing/parser-base.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
adamk
4 years, 2 months ago (2016-09-27 21:40:37 UTC) #1
adamk
Removed SharedFunctionInfo::is_resumable() and FunctionState::is_resumable()
4 years, 2 months ago (2016-09-27 21:57:35 UTC) #6
neis
lgtm thanks
4 years, 2 months ago (2016-09-27 22:04:59 UTC) #9
adamk
+jgruber for debug/
4 years, 2 months ago (2016-09-27 22:08:19 UTC) #11
adamk
hmm, and ulan for heap/
4 years, 2 months ago (2016-09-27 22:08:44 UTC) #13
jgruber
nice, lgtm on debug/
4 years, 2 months ago (2016-09-28 06:50:05 UTC) #16
ulan
On 2016/09/28 06:50:05, jgruber wrote: > nice, lgtm on debug/ heap lgtm
4 years, 2 months ago (2016-09-28 12:52:38 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:24:14 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/622bb78d9b3b92fd384b3867acd30de1cecba5d2
Cr-Commit-Position: refs/heads/master@{#39842}

Powered by Google App Engine
This is Rietveld 408576698