src/runtime/runtime-classes.cc - Issue 2372373002: Remove getters that duplicate FunctionKind in SharedFunctionInfo and ParseInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 2372373002: Remove getters that duplicate FunctionKind in SharedFunctionInfo and ParseInfo (Closed)

Patch Set: Remove SharedFunctionInfo::is_resumable and FunctionState stuff Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index 2ce830a710cc47eebca0007d87b70df2b95dbd40..323604ffdec47047d31e14cd4600fa9e0f78e068 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -95,7 +95,8 @@ static MaybeHandle<Object> DefineClass(Isolate* isolate,

prototype_parent = isolate->factory()->null_value();

} else if (super_class->IsConstructor()) {

DCHECK(!super_class->IsJSFunction() ||

- !Handle<JSFunction>::cast(super_class)->shared()->is_resumable());

+ !IsResumableFunction(

+ Handle<JSFunction>::cast(super_class)->shared()->kind()));

ASSIGN_RETURN_ON_EXCEPTION(

isolate, prototype_parent,

Runtime::GetObjectProperty(isolate, super_class,

« no previous file with comments | « src/parsing/parser-base.h ('k') | src/runtime/runtime-generator.cc » ('j') | no next file with comments »