Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: src/debug/liveedit.cc

Issue 2372373002: Remove getters that duplicate FunctionKind in SharedFunctionInfo and ParseInfo (Closed)
Patch Set: Remove SharedFunctionInfo::is_resumable and FunctionState stuff Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/liveedit.h" 5 #include "src/debug/liveedit.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/compilation-cache.h" 9 #include "src/compilation-cache.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 1539 matching lines...) Expand 10 before | Expand all | Expand 10 after
1550 for (; frame_index < frames.length(); frame_index++) { 1550 for (; frame_index < frames.length(); frame_index++) {
1551 StackFrame* frame = frames[frame_index]; 1551 StackFrame* frame = frames[frame_index];
1552 if (frame->is_exit() || frame->is_builtin_exit()) { 1552 if (frame->is_exit() || frame->is_builtin_exit()) {
1553 non_droppable_frame_found = true; 1553 non_droppable_frame_found = true;
1554 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE; 1554 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE;
1555 break; 1555 break;
1556 } 1556 }
1557 if (frame->is_java_script()) { 1557 if (frame->is_java_script()) {
1558 SharedFunctionInfo* shared = 1558 SharedFunctionInfo* shared =
1559 JavaScriptFrame::cast(frame)->function()->shared(); 1559 JavaScriptFrame::cast(frame)->function()->shared();
1560 if (shared->is_resumable()) { 1560 if (IsResumableFunction(shared->kind())) {
1561 non_droppable_frame_found = true; 1561 non_droppable_frame_found = true;
1562 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR; 1562 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR;
1563 break; 1563 break;
1564 } 1564 }
1565 } 1565 }
1566 if (target.MatchActivation( 1566 if (target.MatchActivation(
1567 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) { 1567 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
1568 target_frame_found = true; 1568 target_frame_found = true;
1569 bottom_js_frame_index = frame_index; 1569 bottom_js_frame_index = frame_index;
1570 } 1570 }
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1916 scope_info_length++; 1916 scope_info_length++;
1917 1917
1918 current_scope = current_scope->outer_scope(); 1918 current_scope = current_scope->outer_scope();
1919 } 1919 }
1920 1920
1921 return scope_info_list; 1921 return scope_info_list;
1922 } 1922 }
1923 1923
1924 } // namespace internal 1924 } // namespace internal
1925 } // namespace v8 1925 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698