components/offline_pages/background/request_queue_in_memory_store.h - Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.h

Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState (Closed)

Patch Set: Addressing feedback from dougarnett Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue.cc ('k') | components/offline_pages/background/request_queue_in_memory_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.h

diff --git a/components/offline_pages/background/request_queue_in_memory_store.h b/components/offline_pages/background/request_queue_in_memory_store.h

index 364de0b1f24fa16c0d246f0746c8789116d020f3..69f2d7297f4433f04cc0937f15fa6558af1f74bc 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.h

+++ b/components/offline_pages/background/request_queue_in_memory_store.h

@@ -34,13 +34,6 @@ class RequestQueueInMemoryStore : public RequestQueueStore {

void RemoveRequests(const std::vector<int64_t>& request_ids,

const RemoveCallback& callback) override;

- // Set the state of associated requests to |new_state|. The callback will get

- // a list of UpdateMultipleRequestResults, and a list of the updated requests.

- void ChangeRequestsState(

- const std::vector<int64_t>& request_ids,

- const SavePageRequest::RequestState new_state,

- const UpdateMultipleRequestsCallback& callback) override;

void Reset(const ResetCallback& callback) override;

private: