Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState (Closed)
Patch Set: Addressing feedback from dougarnett Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.cc
diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc
index 80898030c541959cdcdc07ee4a64b00fac2f85b6..0b562066d8d20159ed7c1a2bd9ce447527bf18ff 100644
--- a/components/offline_pages/background/request_queue.cc
+++ b/components/offline_pages/background/request_queue.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/location.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "components/offline_pages/background/change_requests_state_task.h"
#include "components/offline_pages/background/request_queue_store.h"
#include "components/offline_pages/background/save_page_request.h"
@@ -72,14 +73,6 @@ void UpdateRequestsDone(const RequestQueue::UpdateRequestCallback& callback,
callback.Run(result);
}
-// Handles updating multiple requests at the same time.
-void UpdateMultipleRequestsDone(
- const RequestQueue::UpdateMultipleRequestsCallback& callback,
- const RequestQueue::UpdateMultipleRequestResults& results,
- std::vector<std::unique_ptr<SavePageRequest>> requests) {
- callback.Run(results, std::move(requests));
-}
-
// Completes the remove request call.
void RemoveRequestsDone(
const RequestQueue::RemoveRequestsCallback& callback,
@@ -165,9 +158,10 @@ void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids,
void RequestQueue::ChangeRequestsState(
const std::vector<int64_t>& request_ids,
const SavePageRequest::RequestState new_state,
- const UpdateMultipleRequestsCallback& callback) {
- store_->ChangeRequestsState(request_ids, new_state,
- base::Bind(UpdateMultipleRequestsDone, callback));
+ const RequestQueue::UpdateCallback& callback) {
+ std::unique_ptr<Task> task(new ChangeRequestsStateTask(
+ store_.get(), request_ids, new_state, callback));
+ task_queue_.AddTask(std::move(task));
}
void RequestQueue::PurgeRequests(const PurgeRequestsCallback& callback) {}

Powered by Google App Engine
This is Rietveld 408576698