Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState (Closed)
Patch Set: Addressing feedback from dougarnett Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_in_memory_store.cc
diff --git a/components/offline_pages/background/request_queue_in_memory_store.cc b/components/offline_pages/background/request_queue_in_memory_store.cc
index 1eb2cab972fb54d8746d3e7ece89bc789fb851f5..13ca6aee672fa27a2a45fe1f775e448eb7e77a2f 100644
--- a/components/offline_pages/background/request_queue_in_memory_store.cc
+++ b/components/offline_pages/background/request_queue_in_memory_store.cc
@@ -45,7 +45,7 @@ void RequestQueueInMemoryStore::AddRequest(const SavePageRequest& request,
void RequestQueueInMemoryStore::UpdateRequests(
const std::vector<SavePageRequest>& requests,
- const UpdateCallback& callback) {
+ const RequestQueue::UpdateCallback& callback) {
std::unique_ptr<UpdateRequestsResult> result(
new UpdateRequestsResult(StoreState::LOADED));
@@ -96,35 +96,6 @@ void RequestQueueInMemoryStore::RemoveRequests(
base::Bind(callback, results, base::Passed(std::move(requests))));
}
-void RequestQueueInMemoryStore::ChangeRequestsState(
- const std::vector<int64_t>& request_ids,
- const SavePageRequest::RequestState new_state,
- const UpdateMultipleRequestsCallback& callback) {
- RequestQueue::UpdateMultipleRequestResults results;
- std::vector<std::unique_ptr<SavePageRequest>> requests;
- RequestQueue::UpdateRequestResult result;
- for (int64_t request_id : request_ids) {
- auto pair = requests_.find(request_id);
- // If we find this request id, modify it, and return the modified request in
- // the request list.
- if (pair != requests_.end()) {
- pair->second.set_request_state(new_state);
- std::unique_ptr<SavePageRequest> request(
- new SavePageRequest(pair->second));
- requests.push_back(std::move(request));
- result = RequestQueue::UpdateRequestResult::SUCCESS;
- } else {
- result = RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST;;
- }
-
- results.push_back(std::make_pair(request_id, result));
- }
-
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(callback, results, base::Passed(std::move(requests))));
-}
-
void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {
requests_.clear();
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698