Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2372043002: [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState (Closed)
Patch Set: Addressing feedback from dougarnett Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index 8504c1b1e43e556504f49406f1e54c5c39d94aec..8017ad65fd2c75b0501f2db034c86c373c62355d 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -15,8 +15,6 @@
namespace offline_pages {
-typedef StoreUpdateResult<SavePageRequest> UpdateRequestsResult;
-
// Interface for classes storing save page requests.
class RequestQueueStore {
public:
@@ -26,17 +24,13 @@ class RequestQueueStore {
FAILED, // Add or update attempt failed.
};
+ using UpdateCallback = RequestQueue::UpdateCallback;
+
typedef base::Callback<void(
bool /* success */,
std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
GetRequestsCallback;
typedef base::Callback<void(ItemActionStatus)> AddCallback;
- typedef base::Callback<void(std::unique_ptr<UpdateRequestsResult>)>
- UpdateCallback;
- typedef base::Callback<void(
- const RequestQueue::UpdateMultipleRequestResults& /* statuses*/,
- std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
- UpdateMultipleRequestsCallback;
typedef base::Callback<void(
const RequestQueue::UpdateMultipleRequestResults& /* statuses */,
std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
@@ -65,13 +59,6 @@ class RequestQueueStore {
virtual void RemoveRequests(const std::vector<int64_t>& request_ids,
const RemoveCallback& callback) = 0;
- // Asynchronously changes the state of requests from the store using their
- // request id.
- virtual void ChangeRequestsState(
- const std::vector<int64_t>& request_ids,
- const SavePageRequest::RequestState new_state,
- const UpdateMultipleRequestsCallback& callback) = 0;
-
// Resets the store.
virtual void Reset(const ResetCallback& callback) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698