Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2371773002: Push API: Don't unsubscribe when finding Service Worker fails (Closed)

Created:
4 years, 2 months ago by johnme
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Push API: Don't unsubscribe when finding Service Worker fails Failing to find a service worker might be temporary, so we shouldn't unsubscribe in this case. Continue to unsubscribe if the Service Worker is actually not found (e.g. because it has been unregistered). Also adds more UMA in this area. BUG=642139 Review-Url: https://codereview.chromium.org/2361113002 Cr-Commit-Position: refs/heads/master@{#420447} (cherry picked from commit 983872d32d2b818957e3ba7714b7a822a27e0dd8) Committed: https://chromium.googlesource.com/chromium/src/+/d9b986d87105a963f619d0dd6f6931270721b13b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -5 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years, 2 months ago (2016-09-26 15:20:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9b986d87105a963f619d0dd6f6931270721b13b.

Powered by Google App Engine
This is Rietveld 408576698