Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7926)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 2371773002: Push API: Don't unsubscribe when finding Service Worker fails (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index 68df46d10f61ea1c42f26c60f8d11d699cf69ee0..e067ce7c6bb54fb269a32e3712489c3d33376202 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -668,6 +668,17 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventSuccess) {
EXPECT_TRUE(IsRegisteredKeepAliveEqualTo(true));
ASSERT_TRUE(RunScript("resultQueue.pop()", &script_result));
EXPECT_EQ("testdata", script_result);
+
+ // Check that we record this case in UMA.
+ GetHistogramTester()->ExpectUniqueSample(
+ "PushMessaging.DeliveryStatus.FindServiceWorker",
+ 0 /* SERVICE_WORKER_OK */, 1);
+ GetHistogramTester()->ExpectUniqueSample(
+ "PushMessaging.DeliveryStatus.ServiceWorkerEvent",
+ 0 /* SERVICE_WORKER_OK */, 1);
+ GetHistogramTester()->ExpectUniqueSample(
+ "PushMessaging.DeliveryStatus",
+ content::PUSH_DELIVERY_STATUS_SUCCESS, 1);
}
IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventWithoutPayload) {
@@ -738,6 +749,16 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventNoServiceWorker) {
EXPECT_TRUE(IsRegisteredKeepAliveEqualTo(false));
EXPECT_EQ(app_identifier.app_id(), callback.app_id());
+ // Check that we record this case in UMA.
+ GetHistogramTester()->ExpectUniqueSample(
+ "PushMessaging.DeliveryStatus.FindServiceWorker",
+ 5 /* SERVICE_WORKER_ERROR_NOT_FOUND */, 1);
+ GetHistogramTester()->ExpectTotalCount(
+ "PushMessaging.DeliveryStatus.ServiceWorkerEvent", 0);
+ GetHistogramTester()->ExpectUniqueSample(
+ "PushMessaging.DeliveryStatus",
+ content::PUSH_DELIVERY_STATUS_NO_SERVICE_WORKER, 1);
+
// No push data should have been received.
ASSERT_TRUE(RunScript("resultQueue.popImmediately()", &script_result));
EXPECT_EQ("null", script_result);
« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698