Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2361113002: Push API: Don't unsubscribe when finding Service Worker fails (Closed)

Created:
4 years, 2 months ago by johnme
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Don't unsubscribe when finding Service Worker fails Failing to find a service worker might be temporary, so we shouldn't unsubscribe in this case. Continue to unsubscribe if the Service Worker is actually not found (e.g. because it has been unregistered). Also adds more UMA in this area. BUG=642139 Committed: https://crrev.com/983872d32d2b818957e3ba7714b7a822a27e0dd8 Cr-Commit-Position: refs/heads/master@{#420447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -7 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 4 chunks +26 lines, -2 lines 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
johnme
4 years, 2 months ago (2016-09-22 17:29:46 UTC) #2
Peter Beverloo
lgtm
4 years, 2 months ago (2016-09-22 17:37:23 UTC) #3
johnme
4 years, 2 months ago (2016-09-22 17:42:14 UTC) #5
Ilya Sherman
histograms lgtm
4 years, 2 months ago (2016-09-22 18:43:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361113002/1
4 years, 2 months ago (2016-09-22 19:23:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 20:39:45 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 20:43:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/983872d32d2b818957e3ba7714b7a822a27e0dd8
Cr-Commit-Position: refs/heads/master@{#420447}

Powered by Google App Engine
This is Rietveld 408576698