Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2371583002: [Chromecast] Correct some Cast dependencies in //chrome/browser/ui. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/x/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 18f78d41da2e5887d840e612bb1497d1a4ecf7b9..68bf4916471538c53c4f627d9967ba2bca9ab84b 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -3323,6 +3323,14 @@ split_static_library("ui") {
}
if (is_chromecast && is_linux) {
+ if (is_cast_desktop_build) {
brettw 2016/09/30 21:32:01 Does your build set use_x11? If so, can we just mo
slan 2016/10/03 23:42:57 It doesn't. So I moved the violating source files
+ deps += [
+ "//ui/base/x",
+ "//ui/events/devices/x11",
+ "//ui/events/keycodes:x11",
+ ]
+ }
+
# The Chromecast build sets toolkit_views to false but some targets in the
# build still reference views. But this target is referenced on the Cast
# bot (though not currently compiled) but is configured as Linux. This
@@ -3330,9 +3338,6 @@ split_static_library("ui") {
deps += [
"//chrome/browser/media/router",
"//components/web_modal",
- "//ui/base/x",
- "//ui/events/devices/x11",
- "//ui/events/keycodes:x11",
"//ui/views",
"//ui/views/controls/webview",
]
« no previous file with comments | « no previous file | ui/base/x/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698