Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Issue 23708036: "Fix" for hairline corner bugs (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This CL fills all the holes but will introduce some (hopefully less visible) artifacts.

Patch Set 1 #

Patch Set 2 : Add missing GM file #

Patch Set 3 : Folded new GM into hairlines GM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -49 lines) Patch
M gm/hairlines.cpp View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 8 chunks +66 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
7 years, 3 months ago (2013-09-12 19:18:17 UTC) #1
robertphillips
updated hairlines GM
7 years, 3 months ago (2013-09-12 19:54:57 UTC) #2
bsalomon
On 2013/09/12 19:54:57, robertphillips wrote: > updated hairlines GM lgtm
7 years, 3 months ago (2013-09-12 19:56:39 UTC) #3
robertphillips
I verified that for bench_pictures there is no performance regression with this change.
7 years, 3 months ago (2013-09-13 13:06:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/23708036/7001
7 years, 3 months ago (2013-09-18 21:59:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 3 months ago (2013-09-18 22:03:58 UTC) #6
robertphillips
committed as r11365
7 years, 3 months ago (2013-09-18 22:15:10 UTC) #7
robertphillips
7 years, 3 months ago (2013-09-19 02:24:26 UTC) #8
Message was sent while issue was closed.
This change required rebaselining of the following GMs:

strokes3 hairmodes fatpathfill shadertext2 strokerect  getpostextpath
pathopsinverse dashcubics path-reverse ovals rrect roundrects patheffect
hairlines shadertext3 pathinterior samplerstress complexclip_bw complexclip_aa
complexclip_aa_layer complexclip_bw_layer

Most of these were GPU-only rebaselines except for hairlines where the GM itself
was changed (thus requiring 8888 & 565 rebaselines too)

Powered by Google App Engine
This is Rietveld 408576698