Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: gm/hairlines.cpp

Issue 23708036: "Fix" for hairline corner bugs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Folded new GM into hairlines GM Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/gpu/GrAAHairLinePathRenderer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkTArray.h" 10 #include "SkTArray.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 problem2->moveTo(SkIntToScalar(5), SkIntToScalar(1)); 97 problem2->moveTo(SkIntToScalar(5), SkIntToScalar(1));
98 problem2->lineTo(SkFloatToScalar(4.32787323f), SkFloatToScalar(1.672 12653f)); 98 problem2->lineTo(SkFloatToScalar(4.32787323f), SkFloatToScalar(1.672 12653f));
99 problem2->cubicTo(SkFloatToScalar(2.75223875f), SkFloatToScalar(3.24 776125f), 99 problem2->cubicTo(SkFloatToScalar(2.75223875f), SkFloatToScalar(3.24 776125f),
100 SkFloatToScalar(3.00581908f), SkFloatToScalar(4.51 236057f), 100 SkFloatToScalar(3.00581908f), SkFloatToScalar(4.51 236057f),
101 SkFloatToScalar(3.7580452f), SkFloatToScalar(4.373 67964f)); 101 SkFloatToScalar(3.7580452f), SkFloatToScalar(4.373 67964f));
102 problem2->cubicTo(SkFloatToScalar(4.66472578f), SkFloatToScalar(3.88 8381f), 102 problem2->cubicTo(SkFloatToScalar(4.66472578f), SkFloatToScalar(3.88 8381f),
103 SkFloatToScalar(5.f), SkFloatToScalar(2.875f), 103 SkFloatToScalar(5.f), SkFloatToScalar(2.875f),
104 SkFloatToScalar(5.f), SkFloatToScalar(1.f)); 104 SkFloatToScalar(5.f), SkFloatToScalar(1.f));
105 problem2->close(); 105 problem2->close();
106 } 106 }
107
108 // Three paths that show the same bug (missing end caps)
109 {
110 // A caret (crbug.com/131770)
111 SkPath* bug0 = &fPaths.push_back();
112 bug0->moveTo(6.5f,5.5f);
113 bug0->lineTo(3.5f,0.5f);
114 bug0->moveTo(0.5f,5.5f);
115 bug0->lineTo(3.5f,0.5f);
116 }
117
118 {
119 // An X (crbug.com/137317)
120 SkPath* bug1 = &fPaths.push_back();
121
122 bug1->moveTo(1, 1);
123 bug1->lineTo(6, 6);
124 bug1->moveTo(1, 6);
125 bug1->lineTo(6, 1);
126 }
127
128 {
129 // A right angle (crbug.com/137465 and crbug.com/256776)
130 SkPath* bug2 = &fPaths.push_back();
131
132 bug2->moveTo(5.5f, 5.5f);
133 bug2->lineTo(5.5f, 0.5f);
134 bug2->lineTo(0.5f, 0.5f);
135 }
107 } 136 }
108 137
109 virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { 138 virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE {
110 static const SkAlpha kAlphaValue[] = { 0xFF, 0x40 }; 139 static const SkAlpha kAlphaValue[] = { 0xFF, 0x40 };
111 140
112 enum { 141 enum {
113 kMargin = 5, 142 kMargin = 5,
114 }; 143 };
115 int wrapX = canvas->getDeviceSize().fWidth - kMargin; 144 int wrapX = canvas->getDeviceSize().fWidth - kMargin;
116 145
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 SkTArray<SkPath> fPaths; 187 SkTArray<SkPath> fPaths;
159 typedef GM INHERITED; 188 typedef GM INHERITED;
160 }; 189 };
161 190
162 ////////////////////////////////////////////////////////////////////////////// 191 //////////////////////////////////////////////////////////////////////////////
163 192
164 static GM* MyFactory(void*) { return new HairlinesGM; } 193 static GM* MyFactory(void*) { return new HairlinesGM; }
165 static GMRegistry reg(MyFactory); 194 static GMRegistry reg(MyFactory);
166 195
167 } 196 }
OLDNEW
« no previous file with comments | « no previous file | src/gpu/GrAAHairLinePathRenderer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698