Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: gm/hairlines.cpp

Issue 23708036: "Fix" for hairline corner bugs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Folded new GM into hairlines GM Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrAAHairLinePathRenderer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/hairlines.cpp
===================================================================
--- gm/hairlines.cpp (revision 11234)
+++ gm/hairlines.cpp (working copy)
@@ -104,6 +104,35 @@
SkFloatToScalar(5.f), SkFloatToScalar(1.f));
problem2->close();
}
+
+ // Three paths that show the same bug (missing end caps)
+ {
+ // A caret (crbug.com/131770)
+ SkPath* bug0 = &fPaths.push_back();
+ bug0->moveTo(6.5f,5.5f);
+ bug0->lineTo(3.5f,0.5f);
+ bug0->moveTo(0.5f,5.5f);
+ bug0->lineTo(3.5f,0.5f);
+ }
+
+ {
+ // An X (crbug.com/137317)
+ SkPath* bug1 = &fPaths.push_back();
+
+ bug1->moveTo(1, 1);
+ bug1->lineTo(6, 6);
+ bug1->moveTo(1, 6);
+ bug1->lineTo(6, 1);
+ }
+
+ {
+ // A right angle (crbug.com/137465 and crbug.com/256776)
+ SkPath* bug2 = &fPaths.push_back();
+
+ bug2->moveTo(5.5f, 5.5f);
+ bug2->lineTo(5.5f, 0.5f);
+ bug2->lineTo(0.5f, 0.5f);
+ }
}
virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE {
« no previous file with comments | « no previous file | src/gpu/GrAAHairLinePathRenderer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698