Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 23708030: Get rid of most uses of 'Temporary macro' HEAP (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Get rid of most uses of 'Temporary macro' HEAP R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16622

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -75 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/d8.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/elements.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/externalize-string-extension.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 9 chunks +19 lines, -15 lines 0 comments Download
M src/heap-inl.h View 1 11 chunks +29 lines, -23 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/mark-compact-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-10 12:18:44 UTC) #1
Sven Panne
LGTM with nits. https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h#newcode617 src/heap-inl.h:617: if (FLAG_gc_greedy) ISOLATE->heap()->GarbageCollectionGreedyCheck() Wrap argument in ...
7 years, 3 months ago (2013-09-10 12:55:53 UTC) #2
dcarney
7 years, 3 months ago (2013-09-10 14:30:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698