Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: src/ast.cc

Issue 23708030: Get rid of most uses of 'Temporary macro' HEAP (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 target_ = Handle<JSFunction>::null(); 592 target_ = Handle<JSFunction>::null();
593 cell_ = Handle<Cell>::null(); 593 cell_ = Handle<Cell>::null();
594 ASSERT(lookup->IsFound() && 594 ASSERT(lookup->IsFound() &&
595 lookup->type() == NORMAL && 595 lookup->type() == NORMAL &&
596 lookup->holder() == *global); 596 lookup->holder() == *global);
597 cell_ = Handle<Cell>(global->GetPropertyCell(lookup)); 597 cell_ = Handle<Cell>(global->GetPropertyCell(lookup));
598 if (cell_->value()->IsJSFunction()) { 598 if (cell_->value()->IsJSFunction()) {
599 Handle<JSFunction> candidate(JSFunction::cast(cell_->value())); 599 Handle<JSFunction> candidate(JSFunction::cast(cell_->value()));
600 // If the function is in new space we assume it's more likely to 600 // If the function is in new space we assume it's more likely to
601 // change and thus prefer the general IC code. 601 // change and thus prefer the general IC code.
602 if (!HEAP->InNewSpace(*candidate)) { 602 if (!lookup->isolate()->heap()->InNewSpace(*candidate)) {
603 target_ = candidate; 603 target_ = candidate;
604 return true; 604 return true;
605 } 605 }
606 } 606 }
607 return false; 607 return false;
608 } 608 }
609 609
610 610
611 Handle<JSObject> Call::GetPrototypeForPrimitiveCheck( 611 Handle<JSObject> Call::GetPrototypeForPrimitiveCheck(
612 CheckType check, Isolate* isolate) { 612 CheckType check, Isolate* isolate) {
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value()); 1190 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value());
1191 str = arr; 1191 str = arr;
1192 } else { 1192 } else {
1193 str = DoubleToCString(value_->Number(), buffer); 1193 str = DoubleToCString(value_->Number(), buffer);
1194 } 1194 }
1195 return isolate_->factory()->NewStringFromAscii(CStrVector(str)); 1195 return isolate_->factory()->NewStringFromAscii(CStrVector(str));
1196 } 1196 }
1197 1197
1198 1198
1199 } } // namespace v8::internal 1199 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698