Issue 23707009: Deprecate Persistent functions which were marked to be deprecated.

Issue 23707009: Deprecate Persistent functions which were marked to be deprecated. (Closed)

Created:
7 years, 3 months ago by marja

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Deprecate Persistent functions which were marked to be deprecated. BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16493

Patch Set 2 : Code review (svenpanne) #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -120 lines)			Patch
M	include/v8.h	View		8 chunks	+18 lines, -20 lines	0 comments	Download
M	samples/process.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/d8.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/i18n.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mksnapshot.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View		26 chunks	+63 lines, -64 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-declarative-accessors.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-decls.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-serialize.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-weakmaps.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-weaksets.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

marja

svenpanne, ptal (This needs to wait for https://codereview.chromium.org/23445021/ and https://codereview.chromium.org/23444025/ before landing.)

7 years, 3 months ago (2013-08-30 11:06:40 UTC) #1

Sven Panne

LGTM with a nit. https://codereview.chromium.org/23707009/diff/1/test/cctest/test-declarative-accessors.cc File test/cctest/test-declarative-accessors.cc (right): https://codereview.chromium.org/23707009/diff/1/test/cctest/test-declarative-accessors.cc#newcode42 test/cctest/test-declarative-accessors.cc:42: void Reset(v8::Isolate* isolate) { Remove ...

7 years, 3 months ago (2013-08-30 11:32:28 UTC) #2

marja

Thanks for review! This is now ready to land. svenpanne, can you land it? https://codereview.chromium.org/23707009/diff/1/test/cctest/test-declarative-accessors.cc ...

7 years, 3 months ago (2013-09-02 07:15:49 UTC) #3

Sven Panne

7 years, 3 months ago (2013-09-03 07:34:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16493 (presubmit successful).

Expand Messages | Collapse Messages