src/mksnapshot.cc - Issue 23707009: Deprecate Persistent functions which were marked to be deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mksnapshot.cc

Issue 23707009: Deprecate Persistent functions which were marked to be deprecated. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code review (svenpanne) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mksnapshot.cc

diff --git a/src/mksnapshot.cc b/src/mksnapshot.cc

index c1edcb1b3a149d462dd9e071e0f9fad043c913bd..9e63555b5e218742eef9ad2eda52eac13bc2ebb3 100644

--- a/src/mksnapshot.cc

+++ b/src/mksnapshot.cc

@@ -398,7 +398,7 @@ int main(int argc, char** argv) {

// context even after we have disposed of the context.

HEAP->CollectAllGarbage(i::Heap::kNoGCFlags, "mksnapshot");

i::Object* raw_context = *v8::Utils::OpenPersistent(context);

- context.Dispose(isolate);

+ context.Dispose();

CppByteSink sink(argv[1]);

// This results in a somewhat smaller snapshot, probably because it gets rid

// of some things that are cached between garbage collections.

« no previous file with comments | « src/i18n.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »