Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: src/debug.cc

Issue 23707009: Deprecate Persistent functions which were marked to be deprecated. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code review (svenpanne) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | src/i18n.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 Script** location = 701 Script** location =
702 reinterpret_cast<Script**>(Utils::OpenPersistent(*obj).location()); 702 reinterpret_cast<Script**>(Utils::OpenPersistent(*obj).location());
703 ASSERT((*location)->IsScript()); 703 ASSERT((*location)->IsScript());
704 704
705 // Remove the entry from the cache. 705 // Remove the entry from the cache.
706 int id = (*location)->id()->value(); 706 int id = (*location)->id()->value();
707 script_cache->Remove(reinterpret_cast<void*>(id), Hash(id)); 707 script_cache->Remove(reinterpret_cast<void*>(id), Hash(id));
708 script_cache->collected_scripts_.Add(id); 708 script_cache->collected_scripts_.Add(id);
709 709
710 // Clear the weak handle. 710 // Clear the weak handle.
711 obj->Dispose(isolate); 711 obj->Dispose();
712 } 712 }
713 713
714 714
715 void Debug::SetUp(bool create_heap_objects) { 715 void Debug::SetUp(bool create_heap_objects) {
716 ThreadInit(); 716 ThreadInit();
717 if (create_heap_objects) { 717 if (create_heap_objects) {
718 // Get code to handle debug break on return. 718 // Get code to handle debug break on return.
719 debug_break_return_ = 719 debug_break_return_ =
720 isolate_->builtins()->builtin(Builtins::kReturn_DebugBreak); 720 isolate_->builtins()->builtin(Builtins::kReturn_DebugBreak);
721 ASSERT(debug_break_return_->IsCode()); 721 ASSERT(debug_break_return_->IsCode());
(...skipping 3132 matching lines...) Expand 10 before | Expand all | Expand 10 after
3854 { 3854 {
3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3855 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3856 isolate_->debugger()->CallMessageDispatchHandler(); 3856 isolate_->debugger()->CallMessageDispatchHandler();
3857 } 3857 }
3858 } 3858 }
3859 } 3859 }
3860 3860
3861 #endif // ENABLE_DEBUGGER_SUPPORT 3861 #endif // ENABLE_DEBUGGER_SUPPORT
3862 3862
3863 } } // namespace v8::internal 3863 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/i18n.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698