Issue 237063002: Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing}

Issue 237063002: Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing} (Closed)

Created:
6 years, 8 months ago by fs

Modified:
6 years, 8 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, arv+blink, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing} 'null' should not be allowed per current spec. so modify tests accordingly. BUG=363148 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171474

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	LayoutTests/fast/canvas/draw-focus-if-needed.html	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

lgtm https://codereview.chromium.org/237063002/diff/1/LayoutTests/fast/canvas/draw-focus-if-needed.html File LayoutTests/fast/canvas/draw-focus-if-needed.html (right): https://codereview.chromium.org/237063002/diff/1/LayoutTests/fast/canvas/draw-focus-if-needed.html#newcode19 LayoutTests/fast/canvas/draw-focus-if-needed.html:19: shouldThrow('canvas.drawFocusIfNeeded(null);'); This fixes a spec compliance bug, which ...

6 years, 8 months ago (2014-04-14 14:33:30 UTC) #2

https://codereview.chromium.org/237063002/diff/1/LayoutTests/fast/canvas/draw-focus-if-needed.html File LayoutTests/fast/canvas/draw-focus-if-needed.html (right): https://codereview.chromium.org/237063002/diff/1/LayoutTests/fast/canvas/draw-focus-if-needed.html#newcode19 LayoutTests/fast/canvas/draw-focus-if-needed.html:19: shouldThrow('canvas.drawFocusIfNeeded(null);'); On 2014/04/14 14:33:31, junov wrote: > This fixes ...

6 years, 8 months ago (2014-04-14 15:03:27 UTC) #3

On 2014/04/14 15:03:27, fs wrote: > I figured that since this API was guarded by ...

6 years, 8 months ago (2014-04-14 15:07:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/237063002/1

6 years, 8 months ago (2014-04-14 15:13:14 UTC) #6

Message was sent while issue was closed.

Change committed as 171474

Expand Messages | Collapse Messages