Source/core/html/canvas/CanvasRenderingContext2D.cpp - Issue 237063002: Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.cpp

Issue 237063002: Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing} (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/canvas/CanvasRenderingContext2D.cpp

diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.cpp b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

index a0807a878501ba7dbf78ad80b7d9f2cee8a31d97..15416fab4e632f86bd4bd37840c2bc16ebc767fa 100644

--- a/Source/core/html/canvas/CanvasRenderingContext2D.cpp

+++ b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

@@ -2368,11 +2368,12 @@ bool CanvasRenderingContext2D::drawCustomFocusRing(Element* element)

bool CanvasRenderingContext2D::focusRingCallIsValid(const Path& path, Element* element)

{

+ ASSERT(element);

if (!state().m_invertibleCTM)

return false;

if (path.isEmpty())

return false;

- if (!element || !element->isDescendantOf(canvas()))

+ if (!element->isDescendantOf(canvas()))

return false;

return true;