Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: LayoutTests/fast/canvas/draw-focus-if-needed.html

Issue 237063002: Add StrictTypeChecking to CRC2D.{drawFocusIfNeeded,drawCustomFocusRing} (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/canvas/draw-focus-if-needed.html
diff --git a/LayoutTests/fast/canvas/draw-focus-if-needed.html b/LayoutTests/fast/canvas/draw-focus-if-needed.html
index f5f48143d1ae27769eed034f123c4e4186120cc2..8bfb2ea3bfefca1cead0a7fbe0dd3cb2a3933937 100644
--- a/LayoutTests/fast/canvas/draw-focus-if-needed.html
+++ b/LayoutTests/fast/canvas/draw-focus-if-needed.html
@@ -16,7 +16,7 @@ document.getElementById("button1").focus();
var canvas = document.getElementById("canvas").getContext("2d");
-shouldNotThrow('canvas.drawFocusIfNeeded(null);');
+shouldThrow('canvas.drawFocusIfNeeded(null);');
Justin Novosad 2014/04/14 14:33:31 This fixes a spec compliance bug, which should be
fs 2014/04/14 15:03:28 I figured that since this API was guarded by the E
shouldThrow('canvas.drawFocusIfNeeded();');
canvas.beginPath();
@@ -24,7 +24,7 @@ canvas.rect(50, 50, 200, 100);
canvas.fillStyle = "#ccf";
canvas.fill();
// re-test null case after having defined a path (regression test for crbug.com/353248)
-shouldNotThrow('canvas.drawFocusIfNeeded(null);');
+shouldThrow('canvas.drawFocusIfNeeded(null);');
canvas.drawFocusIfNeeded(document.getElementById("button1"));
canvas.beginPath();
« no previous file with comments | « no previous file | LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698