Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8520)

Unified Diff: blimp/engine/feature/engine_render_widget_feature_unittest.cc

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Observing InputMethod Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/engine_render_widget_feature_unittest.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature_unittest.cc b/blimp/engine/feature/engine_render_widget_feature_unittest.cc
index 63fd04df4cb3c60a1c8b31cafba8d79320ce38da..66d8c1913e4a4c612acdad2b52fcc05b52f8945e 100644
--- a/blimp/engine/feature/engine_render_widget_feature_unittest.cc
+++ b/blimp/engine/feature/engine_render_widget_feature_unittest.cc
@@ -265,8 +265,12 @@ TEST_F(EngineRenderWidgetFeatureTest, ImeRequestSentCorrectly) {
*ime_message_sender_,
MockableProcessMessage(BlimpImeMsgEquals(2, ImeMessage::HIDE_IME), _));
+ std::string text = "green apple";
nyquist 2016/10/05 04:20:56 Should these be declared as anonymous constants? y
+ std::string placeholder = "fruit name";
nyquist 2016/10/05 04:20:56 Will we add support for passing along the placehol
+
feature_.OnRenderWidgetCreated(2, &render_widget_host1_);
- feature_.SendShowImeRequest(2, &render_widget_host1_, &text_input_client_);
+ feature_.SendShowImeRequest(2, &render_widget_host1_,
+ ui::TEXT_INPUT_TYPE_TEXT, text, placeholder);
feature_.SendHideImeRequest(2, &render_widget_host1_);
}

Powered by Google App Engine
This is Rietveld 408576698