Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2520)

Unified Diff: blimp/engine/session/blimp_engine_session.h

Issue 2370393002: Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Observing InputMethod Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/session/blimp_engine_session.h
diff --git a/blimp/engine/session/blimp_engine_session.h b/blimp/engine/session/blimp_engine_session.h
index 0b8c91f461415e75afa4e5e8f78df4a0ec8f656c..720f5fc928a91aac2550634523b3f50e5c3e2779 100644
--- a/blimp/engine/session/blimp_engine_session.h
+++ b/blimp/engine/session/blimp_engine_session.h
@@ -143,6 +143,12 @@ class BlimpEngineSession : public BlimpMessageProcessor,
void NavigationStateChanged(content::WebContents* source,
content::InvalidateTypes changed_flags) override;
nyquist 2016/10/05 04:20:56 Nit: Remove empty line, since this is also part of
+ void OnUpdateTextInputState(content::RenderWidgetHost* render_widget_host,
+ ui::TextInputType type,
+ const std::string& text,
+ const std::string& placeholder,
+ bool show_ime_if_needed) override;
+
// ui::InputMethodObserver overrides.
void OnTextInputTypeChanged(const ui::TextInputClient* client) override;
void OnFocus() override;

Powered by Google App Engine
This is Rietveld 408576698