Extracting placeholder information from Webkit to Blimp

blimp/engine/feature/engine_render_widget_feature_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/feature/engine_render_widget_feature.h"
 
 #include <memory>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 247 matching lines @@
   EXPECT_CALL(
       *ime_message_sender_,
       MockableProcessMessage(BlimpImeMsgEquals(2, 1, ImeMessage::SHOW_IME,
                                                std::string("green apple"), 1),
                              _));
 
   EXPECT_CALL(
       *ime_message_sender_,
       MockableProcessMessage(BlimpImeMsgEquals(2, ImeMessage::HIDE_IME), _));
 
+  std::string text = "green apple";

[nyquist, 2016/10/05 04:20:56]

Should these be declared as anonymous constants? you could possibly use it in
the mock?

+  std::string placeholder = "fruit name";

[nyquist, 2016/10/05 04:20:56]

Will we add support for passing along the placeholder later?

+
   feature_.OnRenderWidgetCreated(2, &render_widget_host1_);
-  feature_.SendShowImeRequest(2, &render_widget_host1_, &text_input_client_);
+  feature_.SendShowImeRequest(2, &render_widget_host1_,
+                              ui::TEXT_INPUT_TYPE_TEXT, text, placeholder);
   feature_.SendHideImeRequest(2, &render_widget_host1_);
 }
 
 TEST_F(EngineRenderWidgetFeatureTest, DropsStaleMessages) {
   InSequence sequence;
   std::vector<uint8_t> payload = { 'f', 'u', 'n' };
   std::vector<uint8_t> new_payload = {'n', 'o', ' ', 'f', 'u', 'n'};
 
   EXPECT_CALL(*render_widget_message_sender_,
               MockableProcessMessage(
@@ skipping 55 matching lines @@
 
   feature_.OnRenderWidgetCreated(1, &render_widget_host1_);
   feature_.OnRenderWidgetCreated(2, &render_widget_host2_);
   feature_.OnRenderWidgetInitialized(1, &render_widget_host1_);
   feature_.OnRenderWidgetDeleted(2, &render_widget_host2_);
   feature_.SendCompositorMessage(1, &render_widget_host1_, payload);
 }
 
 }  // namespace engine
 }  // namespace blimp