Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2370053003: Clean up stale FIXMEs and TODOs in core/animation (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up stale FIXMEs and TODOs in core/animation Committed: https://crrev.com/53147f4a6d7fcb2f6b1f0fcb9d68146ef31acf13 Cr-Commit-Position: refs/heads/master@{#421120}

Patch Set 1 #

Patch Set 2 : Enum change unchange #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp View 1 chunk +0 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h View 1 chunk +0 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +0 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
alancutter (OOO until 2018)
https://codereview.chromium.org/2370053003/diff/20001/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp File third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp (left): https://codereview.chromium.org/2370053003/diff/20001/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp#oldcode12 third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp:12: Generating these will be a consequence of work on ...
4 years, 2 months ago (2016-09-27 01:14:14 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm, thanks
4 years, 2 months ago (2016-09-27 01:16:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370053003/20001
4 years, 2 months ago (2016-09-27 01:52:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148661)
4 years, 2 months ago (2016-09-27 04:20:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370053003/20001
4 years, 2 months ago (2016-09-27 04:57:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 05:53:50 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 05:57:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53147f4a6d7fcb2f6b1f0fcb9d68146ef31acf13
Cr-Commit-Position: refs/heads/master@{#421120}

Powered by Google App Engine
This is Rietveld 408576698