third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 2370053003: Clean up stale FIXMEs and TODOs in core/animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 2370053003: Clean up stale FIXMEs and TODOs in core/animation (Closed)

Patch Set: Enum change unchange Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/animatable/AnimatableImage.cpp ('K') | « third_party/WebKit/Source/core/animation/animatable/AnimatableImage.cpp ('k') | third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index 1736e24a8d5d619300945e1a8fe5e01b61ef9d7f..d199048695c5b533d11d2c0a0e2400cbaa4e39a7 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -308,7 +308,6 @@ static SVGPaintType normalizeSVGPaintType(SVGPaintType paintType)

return paintType == SVG_PAINTTYPE_CURRENTCOLOR ? SVG_PAINTTYPE_RGBCOLOR : paintType;

}

-// FIXME: Generate this function.

PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPropertyID property, const ComputedStyle& style)

{

DCHECK(CSSPropertyMetadata::isInterpolableProperty(property));