Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2370053003: Clean up stale FIXMEs and TODOs in core/animation (Closed)
Patch Set: Enum change unchange Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 if (endKeyframe->offset() != 1) { 146 if (endKeyframe->offset() != 1) {
147 endKeyframe = StringKeyframe::create(); 147 endKeyframe = StringKeyframe::create();
148 endKeyframe->setOffset(1); 148 endKeyframe->setOffset(1);
149 endKeyframe->setEasing(defaultTimingFunction); 149 endKeyframe->setEasing(defaultTimingFunction);
150 keyframes.append(endKeyframe); 150 keyframes.append(endKeyframe);
151 } 151 }
152 DCHECK_GE(keyframes.size(), 2U); 152 DCHECK_GE(keyframes.size(), 2U);
153 DCHECK(!keyframes.first()->offset()); 153 DCHECK(!keyframes.first()->offset());
154 DCHECK_EQ(keyframes.last()->offset(), 1); 154 DCHECK_EQ(keyframes.last()->offset(), 1);
155 155
156 // FIXME: This is only used for use counting neutral keyframes running on th e compositor. 156 // This is used for use counting neutral keyframes running on the compositor .
157 PropertySet allProperties; 157 PropertySet allProperties;
158 for (const auto& keyframe : keyframes) { 158 for (const auto& keyframe : keyframes) {
159 for (const auto& property : keyframe->properties()) 159 for (const auto& property : keyframe->properties())
160 allProperties.add(property.cssProperty()); 160 allProperties.add(property.cssProperty());
161 } 161 }
162 const PropertyHandleSet& startKeyframeProperties = startKeyframe->properties (); 162 const PropertyHandleSet& startKeyframeProperties = startKeyframe->properties ();
163 const PropertyHandleSet& endKeyframeProperties = endKeyframe->properties(); 163 const PropertyHandleSet& endKeyframeProperties = endKeyframe->properties();
164 bool missingStartValues = startKeyframeProperties.size() < allProperties.siz e(); 164 bool missingStartValues = startKeyframeProperties.size() < allProperties.siz e();
165 bool missingEndValues = endKeyframeProperties.size() < allProperties.size(); 165 bool missingEndValues = endKeyframeProperties.size() < allProperties.size();
166 if (missingStartValues || missingEndValues) { 166 if (missingStartValues || missingEndValues) {
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 } 897 }
898 898
899 DEFINE_TRACE(CSSAnimations) 899 DEFINE_TRACE(CSSAnimations)
900 { 900 {
901 visitor->trace(m_transitions); 901 visitor->trace(m_transitions);
902 visitor->trace(m_pendingUpdate); 902 visitor->trace(m_pendingUpdate);
903 visitor->trace(m_runningAnimations); 903 visitor->trace(m_runningAnimations);
904 } 904 }
905 905
906 } // namespace blink 906 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698