[inspector] added inspector test runner [part 5]

[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Committed: https://crrev.com/270db7903af76ec13c57556e5037c6a9c58eee62
Cr-Original-Commit-Position: refs/heads/master@{#39897}
Cr-Commit-Position: refs/heads/master@{#39931}

[kozy, 2016-09-27 00:41:21]

Dmitry, please take a look!

[kozy, 2016-09-27 20:48:30]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 5]

- added most part of inspector-protocol tests that depends only on JavaScript
domains.

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector protocol test runner [part 5]

- added most part of inspector-protocol tests that depends only on JavaScript
domains.

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-27 20:48:30]

kozyatinskiy@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-09-28 10:28:28]

https://codereview.chromium.org/2369753004/diff/40001/test/inspector-protocol...
File test/inspector-protocol/console/let-const-with-api.js (right):

https://codereview.chromium.org/2369753004/diff/40001/test/inspector-protocol...
test/inspector-protocol/console/let-const-with-api.js:2: // Use of this source
code is governed by a BSD-style license that can be
Can you also keep the old copyright line if there was one? E.g. like
https://cs.chromium.org/chromium/src/v8/test/webkit/Array-isArray.js?l=1

[kozy, 2016-09-28 21:21:38]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 5]

- added most part of inspector-protocol tests that depends only on JavaScript
domains.

BUG=chromium:645640
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector protocol test runner [part 5]

- added most part of inspector-protocol tests that depends only on JavaScript
domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-28 22:23:22]

Patchset #4 (id:60001) has been deleted

[kozy, 2016-09-28 22:23:33]

Patchset #4 (id:80001) has been deleted

[kozy, 2016-09-28 22:24:52]

https://codereview.chromium.org/2369753004/diff/40001/test/inspector-protocol...
File test/inspector-protocol/console/let-const-with-api.js (right):

https://codereview.chromium.org/2369753004/diff/40001/test/inspector-protocol...
test/inspector-protocol/console/let-const-with-api.js:2: // Use of this source
code is governed by a BSD-style license that can be
On 2016/09/28 10:28:28, machenbach (slow) wrote:
> Can you also keep the old copyright line if there was one? E.g. like
> https://cs.chromium.org/chromium/src/v8/test/webkit/Array-isArray.js?l=1

In inspector-protocol test we don't have copyright line, e.g:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/inspector...

[kozy, 2016-09-29 05:21:05]

Description was changed from

==========
[inspector] added inspector protocol test runner [part 5]

- added most part of inspector-protocol tests that depends only on JavaScript
domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[dgozman, 2016-09-30 00:56:32]

rs lgtm

[kozy, 2016-09-30 01:39:26]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 01:39:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-09-30 01:48:34]

lgtm

https://codereview.chromium.org/2369753004/diff/100001/test/inspector/runtime...
File test/inspector/runtime/clear-of-command-line-api.js (right):

https://codereview.chromium.org/2369753004/diff/100001/test/inspector/runtime...
test/inspector/runtime/clear-of-command-line-api.js:67: .then(() =>
dumpLeftMethods())
nit: .then(dumpLeftMethod)

[kozy, 2016-09-30 01:49:33]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-09-30 02:01:39]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-30 02:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2369753004/#ps120001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-30 02:01:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-09-30 02:01:59]

All done. thanks!

https://codereview.chromium.org/2369753004/diff/100001/test/inspector/runtime...
File test/inspector/runtime/clear-of-command-line-api.js (right):

https://codereview.chromium.org/2369753004/diff/100001/test/inspector/runtime...
test/inspector/runtime/clear-of-command-line-api.js:67: .then(() =>
dumpLeftMethods())
On 2016/09/30 01:48:33, alph wrote:
> nit: .then(dumpLeftMethod)

Done.

[commit-bot: I haz the power, 2016-09-30 04:50:09]

Description was changed from

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 04:50:10]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-09-30 04:50:25]

Description was changed from

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

[commit-bot: I haz the power, 2016-09-30 04:50:26]

Patchset 5 (id:??) landed as
https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}

[kozy, 2016-09-30 18:04:39]

Description was changed from

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

[kozy, 2016-10-02 20:58:08]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-10-02 20:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 21:22:54]

Description was changed from

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

[commit-bot: I haz the power, 2016-10-02 21:22:55]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-10-02 21:23:11]

Description was changed from

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Cr-Commit-Position: refs/heads/master@{#39897}
==========

to

==========
[inspector] added inspector test runner [part 5]

- added most part of inspector tests that depends only on JavaScript domains.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Committed: https://crrev.com/270db7903af76ec13c57556e5037c6a9c58eee62
Cr-Original-Commit-Position: refs/heads/master@{#39897}
Cr-Commit-Position: refs/heads/master@{#39931}
==========

[commit-bot: I haz the power, 2016-10-02 21:23:13]

Patchset 5 (id:??) landed as
https://crrev.com/270db7903af76ec13c57556e5037c6a9c58eee62
Cr-Commit-Position: refs/heads/master@{#39931}