[inspector] test Runtime.getProperties for set and map [[Entries]]

[inspector] test Runtime.getProperties for set and map [[Entries]]

Added a test that Runtime.getProperties doesn't truncate Set and Map properties in [[Entries]] in internalProperties.

BUG=chromium:650729
R=dgozman@chromium.org

Committed: https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620
Cr-Commit-Position: refs/heads/master@{#39940}

[dgozman, 2016-09-28 20:28:19]

lgtm

https://codereview.chromium.org/2376863002/diff/20001/test/inspector-protocol...
File test/inspector-protocol/runtime/set-or-map-entries.js (right):

https://codereview.chromium.org/2376863002/diff/20001/test/inspector-protocol...
test/inspector-protocol/runtime/set-or-map-entries.js:40: .catch((e) => {
InspectorTest.log(e); InspectorTest.completeTest() })
Remove catch!

[kozy, 2016-09-30 02:04:32]

All done.

https://codereview.chromium.org/2376863002/diff/20001/test/inspector-protocol...
File test/inspector-protocol/runtime/set-or-map-entries.js (right):

https://codereview.chromium.org/2376863002/diff/20001/test/inspector-protocol...
test/inspector-protocol/runtime/set-or-map-entries.js:40: .catch((e) => {
InspectorTest.log(e); InspectorTest.completeTest() })
On 2016/09/28 20:28:19, dgozman wrote:
> Remove catch!

Done.

[kozy, 2016-09-30 02:05:00]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org

[kozy, 2016-09-30 02:05:01]

Alexey, please take a look!

[kozy, 2016-09-30 02:11:21]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 02:11:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 02:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 02:38:45]

Dry run: This issue passed the CQ dry run.

[alph, 2016-10-03 20:21:40]

lgtm

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
File test/inspector/runtime/set-or-map-entries.js (right):

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
test/inspector/runtime/set-or-map-entries.js:37: .then((result) =>
InspectorTest.sendCommandPromise("Runtime.getProperties", { ownProperties: true,
objectId: result.result.result.objectId }))
nit: no need for () if there's a single argument

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
test/inspector/runtime/set-or-map-entries.js:46: properties =
properties.filter((property) => property.name === "[[Entries]]");
nit: s/filter/find/

[kozy, 2016-10-03 20:57:12]

Thanks! all done.

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
File test/inspector/runtime/set-or-map-entries.js (right):

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
test/inspector/runtime/set-or-map-entries.js:37: .then((result) =>
InspectorTest.sendCommandPromise("Runtime.getProperties", { ownProperties: true,
objectId: result.result.result.objectId }))
On 2016/10/03 20:21:40, alph wrote:
> nit: no need for () if there's a single argument

Done.

https://codereview.chromium.org/2376863002/diff/60001/test/inspector/runtime/...
test/inspector/runtime/set-or-map-entries.js:46: properties =
properties.filter((property) => property.name === "[[Entries]]");
On 2016/10/03 20:21:40, alph wrote:
> nit: s/filter/find/

Done.

[kozy, 2016-10-03 20:57:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-03 20:57:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2376863002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-03 20:57:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:22:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-03 21:22:17]

Description was changed from

==========
[inspector] test Runtime.getProperties for set and map [[Entries]]

Added a test that Runtime.getProperties doesn't truncate Set and Map properties
in [[Entries]] in internalProperties.

BUG=chromium:650729
R=dgozman@chromium.org
==========

to

==========
[inspector] test Runtime.getProperties for set and map [[Entries]]

Added a test that Runtime.getProperties doesn't truncate Set and Map properties
in [[Entries]] in internalProperties.

BUG=chromium:650729
R=dgozman@chromium.org

Committed: https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620
Cr-Commit-Position: refs/heads/master@{#39940}
==========

[commit-bot: I haz the power, 2016-10-03 21:22:18]

Patchset 5 (id:??) landed as
https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620
Cr-Commit-Position: refs/heads/master@{#39940}